From: Eric Blake <eblake@redhat.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] 9pfs: fail local_statfs() earlier
Date: Fri, 3 Mar 2017 12:15:08 -0600 [thread overview]
Message-ID: <cc7aa908-4f7c-20d9-9cfe-982ab83a26b3@redhat.com> (raw)
In-Reply-To: <148856422757.9841.6298006998523421948.stgit@bahia.lan>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On 03/03/2017 12:03 PM, Greg Kurz wrote:
> If we cannot open the given path, we can return right away instead of
> passing -1 to fstatfs() and close(). This will make Coverity happy.
>
> (Coverity issue CID1371729)
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> hw/9pfs/9p-local.c | 3 +++
> 1 file changed, 3 insertions(+)
No difference in end-user observable behavior, but arguably nicer (and
always more efficient to avoid unneeded syscalls).
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-03 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 18:03 [Qemu-devel] [PATCH] 9pfs: fail local_statfs() earlier Greg Kurz
2017-03-03 18:13 ` Daniel P. Berrange
2017-03-03 18:15 ` Eric Blake [this message]
2017-03-03 20:00 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7aa908-4f7c-20d9-9cfe-982ab83a26b3@redhat.com \
--to=eblake@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).