From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjrjW-0006nu-KZ for qemu-devel@nongnu.org; Fri, 03 Mar 2017 13:15:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjrjS-0000lP-Ip for qemu-devel@nongnu.org; Fri, 03 Mar 2017 13:15:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51034) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cjrjS-0000kh-D2 for qemu-devel@nongnu.org; Fri, 03 Mar 2017 13:15:10 -0500 References: <148856422757.9841.6298006998523421948.stgit@bahia.lan> From: Eric Blake Message-ID: Date: Fri, 3 Mar 2017 12:15:08 -0600 MIME-Version: 1.0 In-Reply-To: <148856422757.9841.6298006998523421948.stgit@bahia.lan> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DjNslXs5RGGDgoCXKlkS1nJR9mrQL5bc1" Subject: Re: [Qemu-devel] [PATCH] 9pfs: fail local_statfs() earlier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DjNslXs5RGGDgoCXKlkS1nJR9mrQL5bc1 From: Eric Blake To: Greg Kurz , qemu-devel@nongnu.org Cc: "Daniel P. Berrange" Message-ID: Subject: Re: [PATCH] 9pfs: fail local_statfs() earlier References: <148856422757.9841.6298006998523421948.stgit@bahia.lan> In-Reply-To: <148856422757.9841.6298006998523421948.stgit@bahia.lan> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/03/2017 12:03 PM, Greg Kurz wrote: > If we cannot open the given path, we can return right away instead of > passing -1 to fstatfs() and close(). This will make Coverity happy. >=20 > (Coverity issue CID1371729) >=20 > Signed-off-by: Greg Kurz > --- > hw/9pfs/9p-local.c | 3 +++ > 1 file changed, 3 insertions(+) No difference in end-user observable behavior, but arguably nicer (and always more efficient to avoid unneeded syscalls). Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DjNslXs5RGGDgoCXKlkS1nJR9mrQL5bc1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYubKsAAoJEKeha0olJ0NqsykH/0QvaoxO7Hts3UF0aRXvCAQu vp5cbCCOwFchWt7w0iQ7+AZLZVQ+XN0p+iwMpfHMAkID+X8E8joe6KVx8StVDdhl IOoyKqFa2o92IoYQKRS10ZVNjwjfCfITw5VUItVW1qIEgzIbJjfY0NeDT2BkLLEe oEcoC+JRQ1jXAdgfyp5jB6DCN8jissA7ZQ7g4DmNcY8YTyUdqOg3VdKzxd8T+Ink QIyj95ePBqiFgsnW+emNCBefsV/UUrkVNo4vo/oBgwvo2RYQyhMTHapm2QJ+tLU8 Px9UjnwieLxMuYvjIYQfCBwYa6/GD5ns89P2+EbBliYNqZ9tOthk2C9JZI8uOvc= =J6kH -----END PGP SIGNATURE----- --DjNslXs5RGGDgoCXKlkS1nJR9mrQL5bc1--