From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Ani Sinha <ani@anisinha.ca>,
qemu-devel@nongnu.org, mst@redhat.com,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH 5/7] hw/smbios: code cleanup - use macro definitions for table header handles
Date: Thu, 24 Feb 2022 08:26:12 +0100 [thread overview]
Message-ID: <cc7dd33b-d209-4878-016e-480956784dae@gmail.com> (raw)
In-Reply-To: <20220223143322.927136-6-ani@anisinha.ca>
On 23/2/22 15:33, Ani Sinha wrote:
> This is a minor cleanup. Using macro definitions makes the code more
> readable. It is at once clear which tables use which handle numbers in their
> header. It also makes it easy to calculate the gaps between the numbers and
> update them if needed.
>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> ---
> hw/smbios/smbios.c | 38 ++++++++++++++++++++++++++------------
> 1 file changed, 26 insertions(+), 12 deletions(-)
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-02-24 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 14:33 [PATCH 0/7] Queued patches for the next pull request Ani Sinha
2022-02-23 14:33 ` [PATCH 1/7] ACPI ERST: specification for ERST support Ani Sinha
2022-02-23 14:33 ` [PATCH 2/7] MAINTAINERS: no need to add my name explicitly as a reviewer for VIOT tables Ani Sinha
2022-02-23 14:33 ` [PATCH 3/7] docs/acpi/erst: add device id for ACPI ERST device in pci-ids.txt Ani Sinha
2022-02-23 14:33 ` [PATCH 4/7] hw/acpi/erst: clean up unused IS_UEFI_CPER_RECORD macro Ani Sinha
2022-02-23 14:33 ` [PATCH 5/7] hw/smbios: code cleanup - use macro definitions for table header handles Ani Sinha
2022-02-24 7:26 ` Philippe Mathieu-Daudé [this message]
2022-02-23 14:33 ` [PATCH 6/7] hw/smbios: fix overlapping table handle numbers with large memory vms Ani Sinha
2022-02-23 14:33 ` [PATCH 7/7] hw/smbios: add assertion to ensure handles of tables 19 and 32 do not collide Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7dd33b-d209-4878-016e-480956784dae@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=ani@anisinha.ca \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).