From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Cc: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)
Date: Tue, 9 Mar 2021 17:26:18 +0100 [thread overview]
Message-ID: <cc8baef6-8e5c-aaee-f383-38e541a491a4@redhat.com> (raw)
In-Reply-To: <75f9eac2-9981-ee1f-b158-5d1136c993c6@redhat.com>
On 09/03/2021 15.45, Paolo Bonzini wrote:
> On 09/03/21 15:29, Thomas Huth wrote:
>> When trying to remove the -usbdevice option, there were complaints that
>> "-usbdevice braille" is still a very useful shortcut for some people.
>> Thus we never remove this option. Since it's not such a big burden to
>> keep it around, and it's also convenient in the sense that you don't
>> have to worry to enable a host controller explicitly with this option,
>> we should remove it from he deprecation list again, and rather properly
>> document the possible device for this option instead.
>>
>> However, there is one exception: "-usbdevice audio" should go away, since
>> audio devices without "audiodev=..." parameter are also on the deprecation
>> list and you cannot use "-usbdevice audio" with "audiodev".
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> It's missing an addition to docs/system/removed-features.rst for "-usbdevice
> audio"; otherwise looks good.
Well, I guess hardly anybody ever used this since it was completely
undocumented (try to google it - I just got one
result), but yeah, let's better document it that it's gone
now. I'll send a v2.
Thomas
prev parent reply other threads:[~2021-03-09 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 14:29 [PATCH] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed) Thomas Huth
2021-03-09 14:45 ` Paolo Bonzini
2021-03-09 16:26 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc8baef6-8e5c-aaee-f383-38e541a491a4@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).