From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32948)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1bCl6H-0000Rr-43
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 05:57:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1bCl6C-0006dv-Vx
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 05:57:36 -0400
Received: from mout.kundenserver.de ([212.227.17.10]:55716)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1bCl6C-0006do-LY
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 05:57:32 -0400
References: <1465897927-4719-1-git-send-email-peter.maydell@linaro.org>
	<1465897927-4719-2-git-send-email-peter.maydell@linaro.org>
From: Laurent Vivier <laurent@vivier.eu>
Message-ID: <cc8d3bbd-f598-81d2-a3e2-08a6f147549d@vivier.eu>
Date: Tue, 14 Jun 2016 11:57:24 +0200
MIME-Version: 1.0
In-Reply-To: <1465897927-4719-2-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/5] configure: Don't override ARCH=unknown
 if enabling TCI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Riku Voipio <riku.voipio@linaro.org>, Richard Henderson <rth@twiddle.net>



Le 14/06/2016 à 11:52, Peter Maydell a écrit :
> At the moment if configure finds an unknown CPU it will set
> ARCH to 'unknown', and then later either bail out or set it
> to 'tci' (depending on whether the user passed configure the
> --enable-tcg-interpreter switch). This is unnecessarily
> confusing, because we could be using TCI in two cases:
>  * a known host architecture (in which case ARCH is set to
>    the actual host architecture, like 'i386')
>  * an unknown host architecture (in which case ARCH is
>    set to 'tci')
> so nothing can rely on ARCH=tci to mean "using TCI".
> Remove the line setting ARCH, so we leave it as "unknown",
> which is what the actual situation is.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

> ---
>  configure | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 8c2f90b..7ab4e0b 100755
> --- a/configure
> +++ b/configure
> @@ -1381,7 +1381,6 @@ fi
>  if test "$ARCH" = "unknown"; then
>      if test "$tcg_interpreter" = "yes" ; then
>          echo "Unsupported CPU = $cpu, will use TCG with TCI (experimental)"
> -        ARCH=tci
>      else
>          error_exit "Unsupported CPU = $cpu, try --enable-tcg-interpreter"
>      fi
>