* [PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header
@ 2024-09-26 10:21 Philippe Mathieu-Daudé
2024-09-26 11:35 ` Manos Pitsidianakis
2024-10-03 18:59 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-09-26 10:21 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Manos Pitsidianakis, Michael S. Tsirkin,
Gerd Hoffmann, Philippe Mathieu-Daudé
We were including the "exec/tswap.h" header to get
target_words_bigendian() declaration, but since commit a276ec8e26
("hw/audio/virtio-snd: Always use little endian audio format")
removed this method call, we don't need this header anymore.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/audio/virtio-snd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
index 69838181dd..c5581d7b3d 100644
--- a/hw/audio/virtio-snd.c
+++ b/hw/audio/virtio-snd.c
@@ -20,7 +20,6 @@
#include "qemu/log.h"
#include "qemu/error-report.h"
#include "qemu/lockable.h"
-#include "exec/tswap.h"
#include "sysemu/runstate.h"
#include "trace.h"
#include "qapi/error.h"
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header
2024-09-26 10:21 [PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header Philippe Mathieu-Daudé
@ 2024-09-26 11:35 ` Manos Pitsidianakis
2024-10-03 18:59 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Manos Pitsidianakis @ 2024-09-26 11:35 UTC (permalink / raw)
To: Philippe Mathieu-Daudé , qemu-devel
Cc: qemu-trivial, Manos Pitsidianakis, Michael S. Tsirkin,
Gerd Hoffmann, Philippe Mathieu-Daudé
On Thu, 26 Sep 2024 13:21, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>We were including the "exec/tswap.h" header to get
>target_words_bigendian() declaration, but since commit a276ec8e26
>("hw/audio/virtio-snd: Always use little endian audio format")
>removed this method call, we don't need this header anymore.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>---
> hw/audio/virtio-snd.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
>index 69838181dd..c5581d7b3d 100644
>--- a/hw/audio/virtio-snd.c
>+++ b/hw/audio/virtio-snd.c
>@@ -20,7 +20,6 @@
> #include "qemu/log.h"
> #include "qemu/error-report.h"
> #include "qemu/lockable.h"
>-#include "exec/tswap.h"
> #include "sysemu/runstate.h"
> #include "trace.h"
> #include "qapi/error.h"
>--
>2.45.2
>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header
2024-09-26 10:21 [PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header Philippe Mathieu-Daudé
2024-09-26 11:35 ` Manos Pitsidianakis
@ 2024-10-03 18:59 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2024-10-03 18:59 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Manos Pitsidianakis, Michael S. Tsirkin,
Gerd Hoffmann
On 9/26/24 03:21, Philippe Mathieu-Daudé wrote:
> We were including the "exec/tswap.h" header to get
> target_words_bigendian() declaration, but since commit a276ec8e26
> ("hw/audio/virtio-snd: Always use little endian audio format")
> removed this method call, we don't need this header anymore.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> hw/audio/virtio-snd.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-03 18:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-26 10:21 [PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header Philippe Mathieu-Daudé
2024-09-26 11:35 ` Manos Pitsidianakis
2024-10-03 18:59 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).