[Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Thomas Huth]

cirrus-ci.com also has the possibility to run CI tasks on macOS.
Since most of the QEMU developers do not have access to macOS yet,
let's add a CI pipeline for this operating system here, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 You can see an example here: https://cirrus-ci.com/task/5099494325616640

 .cirrus.yml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/.cirrus.yml b/.cirrus.yml
index 303fe72..e3d375b 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -14,3 +14,15 @@ freebsd_12_task:
     - ../configure || { cat config.log; exit 1; }
     - gmake -j8
     - gmake -j8 V=1 check
+
+macos_task:
+  osx_instance:
+    image: high-sierra-base
+  env:
+    CIRRUS_CLONE_DEPTH: 1
+  install_script:
+    - brew install pkg-config glib pixman make sdl2
+  script:
+    - ./configure || { cat config.log; exit 1; }
+    - gmake -j$(sysctl -n hw.ncpu)
+    - gmake check -j$(sysctl -n hw.ncpu)
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Philippe Mathieu-Daudé]

On 3/4/19 11:32 AM, Thomas Huth wrote:
> cirrus-ci.com also has the possibility to run CI tasks on macOS.
> Since most of the QEMU developers do not have access to macOS yet,
> let's add a CI pipeline for this operating system here, too.

Can we get report of failures? (IRC, mail to ML, patchew icon)

> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  You can see an example here: https://cirrus-ci.com/task/5099494325616640
> 
>  .cirrus.yml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/.cirrus.yml b/.cirrus.yml
> index 303fe72..e3d375b 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -14,3 +14,15 @@ freebsd_12_task:
>      - ../configure || { cat config.log; exit 1; }
>      - gmake -j8
>      - gmake -j8 V=1 check
> +
> +macos_task:
> +  osx_instance:
> +    image: high-sierra-base
> +  env:
> +    CIRRUS_CLONE_DEPTH: 1
> +  install_script:
> +    - brew install pkg-config glib pixman make sdl2
> +  script:
> +    - ./configure || { cat config.log; exit 1; }
> +    - gmake -j$(sysctl -n hw.ncpu)
> +    - gmake check -j$(sysctl -n hw.ncpu)
> 

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Thomas Huth]

On 04/03/2019 12.08, Philippe Mathieu-Daudé wrote:
> On 3/4/19 11:32 AM, Thomas Huth wrote:
>> cirrus-ci.com also has the possibility to run CI tasks on macOS.
>> Since most of the QEMU developers do not have access to macOS yet,
>> let's add a CI pipeline for this operating system here, too.
> 
> Can we get report of failures? (IRC, mail to ML, patchew icon)

Honestly, I've got no clue ... this is the only help text that I've
found so far:

 https://cirrus-ci.org/guide/notifications/

  Thomas

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Ed Maste]

On Mon, 4 Mar 2019 at 06:39, Thomas Huth <thuth@redhat.com> wrote:
> >
> > Can we get report of failures? (IRC, mail to ML, patchew icon)
>
> Honestly, I've got no clue ... this is the only help text that I've
> found so far:
>
>  https://cirrus-ci.org/guide/notifications/

I asked on twitter and was pointed at that same link, which in turn
leads to https://github.com/cirrus-actions/email but I'm not quite
sure what to do with it.

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Ed Maste]

On Mon, 4 Mar 2019 at 07:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 3/4/19 11:32 AM, Thomas Huth wrote:
> > cirrus-ci.com also has the possibility to run CI tasks on macOS.
> > Since most of the QEMU developers do not have access to macOS yet,
> > let's add a CI pipeline for this operating system here, too.
>
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Ed Maste <emaste@freebsd.org>

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Thomas Huth]

On 07/03/2019 21.26, Ed Maste wrote:
> On Mon, 4 Mar 2019 at 07:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> On 3/4/19 11:32 AM, Thomas Huth wrote:
>>> cirrus-ci.com also has the possibility to run CI tasks on macOS.
>>> Since most of the QEMU developers do not have access to macOS yet,
>>> let's add a CI pipeline for this operating system here, too.
>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Acked-by: Ed Maste <emaste@freebsd.org>

Thanks! I can take this patch through my qtest tree.

 Thomas

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Li-Wen Hsu]

On Fri, Mar 8, 2019 at 4:30 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 07/03/2019 21.26, Ed Maste wrote:
> > On Mon, 4 Mar 2019 at 07:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> >>
> >> On 3/4/19 11:32 AM, Thomas Huth wrote:
> >>> cirrus-ci.com also has the possibility to run CI tasks on macOS.
> >>> Since most of the QEMU developers do not have access to macOS yet,
> >>> let's add a CI pipeline for this operating system here, too.
> >>
> >>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Acked-by: Ed Maste <emaste@freebsd.org>
>
> Thanks! I can take this patch through my qtest tree.

Hi Thomas,

Sorry for the late reply, I checked and tested the patch, it works
fine.  BTW, may I suggest:

>From https://cirrus-ci.org/guide/macOS/ , the image high-sierra-base
is lasted as "Not maintained", how about change to mojave-base?

Also, perhaps we can put the common:

env:
  CIRRUS_CLONE_DEPTH: 1

in the global area?

Thanks,
Li-wen

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Thomas Huth]

On 07/03/2019 22.52, Li-Wen Hsu wrote:
> On Fri, Mar 8, 2019 at 4:30 AM Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 07/03/2019 21.26, Ed Maste wrote:
>>> On Mon, 4 Mar 2019 at 07:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>>>
>>>> On 3/4/19 11:32 AM, Thomas Huth wrote:
>>>>> cirrus-ci.com also has the possibility to run CI tasks on macOS.
>>>>> Since most of the QEMU developers do not have access to macOS yet,
>>>>> let's add a CI pipeline for this operating system here, too.
>>>>
>>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Acked-by: Ed Maste <emaste@freebsd.org>
>>
>> Thanks! I can take this patch through my qtest tree.
> 
> Hi Thomas,
> 
> Sorry for the late reply, I checked and tested the patch, it works
> fine.  BTW, may I suggest:
> 
> From https://cirrus-ci.org/guide/macOS/ , the image high-sierra-base
> is lasted as "Not maintained", how about change to mojave-base?

Definitely! Not sure how I could have missed that... I was either blind,
or, how I remember it, the high-sierra-base image was not marked as
unmaintained yet and marked as the only image that had the brew system
pre-installed back then. Anyway, I've now switched to mojave-base and it
seems to work fine, too.

> Also, perhaps we can put the common:
> 
> env:
>   CIRRUS_CLONE_DEPTH: 1
> 
> in the global area?

Sure! I'll do that in v2.

 Thanks for the review,
  Thomas

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Paolo Bonzini]

On 04/03/19 12:08, Philippe Mathieu-Daudé wrote:
> +macos_task:
> +  osx_instance:
> +    image: high-sierra-base
> +  env:
> +    CIRRUS_CLONE_DEPTH: 1
> +  install_script:
> +    - brew install pkg-config glib pixman make sdl2

Could you also install Python 3 ("python" in Homebrew is 3.7) and avoid
Apple's obsolete /usr/bin/python (also needs something like
--python=/usr/local/bin/python3 in ./configure below).

Thanks,

Paolo

> +  script:
> +    - ./configure || { cat config.log; exit 1; }
> +    - gmake -j$(sysctl -n hw.ncpu)
> +    - gmake check -j$(sysctl -n hw.ncpu)

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

[Thomas Huth]

On 07/03/2019 22.10, Paolo Bonzini wrote:
> On 04/03/19 12:08, Philippe Mathieu-Daudé wrote:
>> +macos_task:
>> +  osx_instance:
>> +    image: high-sierra-base
>> +  env:
>> +    CIRRUS_CLONE_DEPTH: 1
>> +  install_script:
>> +    - brew install pkg-config glib pixman make sdl2
> 
> Could you also install Python 3 ("python" in Homebrew is 3.7) and avoid
> Apple's obsolete /usr/bin/python (also needs something like
> --python=/usr/local/bin/python3 in ./configure below).

Yes, can do.

 Thomas