From: Fiona Ebner <f.ebner@proxmox.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org, kraxel@redhat.com,
mcascell@redhat.com
Subject: Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer
Date: Wed, 6 Dec 2023 09:59:14 +0100 [thread overview]
Message-ID: <cca30ea8-b548-46ee-89d4-ea6595bd0fce@proxmox.com> (raw)
In-Reply-To: <CAJ+F1CKPQ_6p8Lc3iBP-FM=ke1VS4bjL=JzHm+H-uiNR=x_R+A@mail.gmail.com>
Am 04.12.23 um 08:30 schrieb Marc-André Lureau:
> Hi
>
> On Tue, Nov 28, 2023 at 2:52 PM Marc-André Lureau
> <marcandre.lureau@gmail.com> wrote:
>>
>>
>> It's hard to make the best decision.
>>
>> We could return the uncompressed data so far, that would fix the
>> regression. But potentially, we have incomplete data returned. Clients
>> should be fixed to include Z_STREAM_END marker (using Z_FINISH).
>>
>
> I'll queue your patch for 8.2. thanks
>
Thanks to you for looking into the issue!
A colleague of mine now opened a bug report for noVNC and according to
the the maintainer there, the protocol does not require setting an end
marker: https://github.com/novnc/noVNC/issues/1820#issuecomment-1841014968
Best Regards,
Fiona
prev parent reply other threads:[~2023-12-06 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 12:58 [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer Fiona Ebner
2023-11-22 13:06 ` Marc-André Lureau
2023-11-22 13:25 ` Fiona Ebner
2023-11-23 6:52 ` Marc-André Lureau
2023-11-23 8:46 ` Fiona Ebner
2023-11-27 9:15 ` Marc-André Lureau
2023-11-27 10:51 ` Fiona Ebner
2023-11-28 10:52 ` Marc-André Lureau
2023-12-04 7:30 ` Marc-André Lureau
2023-12-06 8:59 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cca30ea8-b548-46ee-89d4-ea6595bd0fce@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mcascell@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).