From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3680BC4338F for ; Tue, 10 Aug 2021 09:11:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79B4F61058 for ; Tue, 10 Aug 2021 09:11:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 79B4F61058 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDNnf-0004HY-Cq for qemu-devel@archiver.kernel.org; Tue, 10 Aug 2021 05:11:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDNl1-00021a-Ap for qemu-devel@nongnu.org; Tue, 10 Aug 2021 05:09:11 -0400 Received: from 3.mo548.mail-out.ovh.net ([188.165.32.156]:53241) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDNkz-0008EY-1E for qemu-devel@nongnu.org; Tue, 10 Aug 2021 05:09:11 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.109.143.103]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 0BE26201CE; Tue, 10 Aug 2021 09:09:06 +0000 (UTC) Received: from kaod.org (37.59.142.105) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Tue, 10 Aug 2021 11:09:05 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-105G006bbc12c1f-6d2b-48c7-948c-06459a5084a5, 8F36BE46FB8773C29BD4C9A30C998E4B5B7B2B54) smtp.auth=clg@kaod.org X-OVh-ClientIp: 90.89.73.13 Subject: Re: [PATCH] tests/acceptance: Test powernv machines To: Joel Stanley References: <20210810083346.730652-1-clg@kaod.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: Date: Tue, 10 Aug 2021 11:09:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.105] X-ClientProxiedBy: DAG7EX2.mxp5.local (172.16.2.62) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 56119a15-ace4-4f2d-869c-f4d12f506532 X-Ovh-Tracer-Id: 4769593480374815596 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvtddrjeelgddufecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeehuedtheeghfdvhedtueelteegvdefueektdefiefhffffieduuddtudfhgfevtdenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehgrhhouhhgsehkrghougdrohhrgh Received-SPF: pass client-ip=188.165.32.156; envelope-from=clg@kaod.org; helo=3.mo548.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , Wainer dos Santos Moschetta , Greg Kurz , qemu-ppc@nongnu.org, Cleber Rosa , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/10/21 10:36 AM, Joel Stanley wrote: > On Tue, 10 Aug 2021 at 08:34, Cédric Le Goater wrote: >> >> Fetch the OpenPOWER images to boot the powernv8 and powernv9 machines >> with a simple PCI layout. >> >> Cc: Cleber Rosa >> Cc: Wainer dos Santos Moschetta >> Signed-off-by: Cédric Le Goater >> --- >> tests/acceptance/boot_linux_console.py | 42 ++++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py >> index 5248c8097df9..da93a475ca87 100644 >> --- a/tests/acceptance/boot_linux_console.py >> +++ b/tests/acceptance/boot_linux_console.py >> @@ -1176,6 +1176,48 @@ def test_ppc64_e500(self): >> tar_hash = '6951d86d644b302898da2fd701739c9406527fe1' >> self.do_test_advcal_2018('19', tar_hash, 'uImage') >> >> + def do_test_ppc64_powernv(self, proc): >> + >> + images_url = ('https://github.com/open-power/op-build/releases/download/v2.7/') >> + >> + skiboot_url = images_url + 'skiboot.lid' >> + skiboot_hash = 'a9ffcddbf238f86cda4b2cae2882d6bd13cff8489109758a4980efaf154f4a29' >> + skiboot_path = self.fetch_asset(skiboot_url, asset_hash=skiboot_hash, >> + algorithm='sha256') > > What's the thought that led you to using this instead of the one that > gets packaged with qemu? Good question. I considered that the skiboot.lid shipped with QEMU was somewhat a default to make things work. The official released versions are the ones used by the outside world on real systems and were a better target for tests. That said, using the default version might be enough. Maintainers, please advise ! >> + >> + kernel_url = images_url + 'zImage.epapr' >> + kernel_hash = '0ab237df661727e5392cee97460e8674057a883c5f74381a128fa772588d45cd' >> + kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash, >> + algorithm='sha256') >> + self.vm.set_console() >> + self.vm.add_args('-bios', skiboot_path, >> + '-kernel', kernel_path, >> + '-append', 'console=tty0 console=hvc0', >> + '-device', 'pcie-pci-bridge,id=bridge1,bus=pcie.1,addr=0x0', >> + '-device', 'nvme,bus=pcie.2,addr=0x0,serial=1234', >> + '-device', 'e1000e,bus=bridge1,addr=0x3', >> + '-device', 'nec-usb-xhci,bus=bridge1,addr=0x2') >> + self.vm.launch() >> + >> + self.wait_for_console_pattern("CPU: " + proc + " generation processor") >> + self.wait_for_console_pattern("zImage starting: loaded") >> + self.wait_for_console_pattern("Run /init as init process") >> + self.wait_for_console_pattern("Creating 1 MTD partitions") > > This is great. > > Is there any value in checking for some of the devices that come up, > like USB or ethernet? or nvme. Yes. That's a good idea. > Reviewed-by: Joel Stanley Thanks, C. > >> + >> + def test_ppc_powernv8(self): >> + """ >> + :avocado: tags=arch:ppc64 >> + :avocado: tags=machine:powernv8 >> + """ >> + self.do_test_ppc64_powernv('P8') >> + >> + def test_ppc_powernv9(self): >> + """ >> + :avocado: tags=arch:ppc64 >> + :avocado: tags=machine:powernv9 >> + """ >> + self.do_test_ppc64_powernv('P9') >> + >> def test_ppc_g3beige(self): >> """ >> :avocado: tags=arch:ppc >> -- >> 2.31.1 >>