From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJHqQ-0005CB-W0 for qemu-devel@nongnu.org; Tue, 20 Dec 2016 05:40:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJHqM-0000Fa-Tu for qemu-devel@nongnu.org; Tue, 20 Dec 2016 05:40:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39236) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cJHqM-0000EU-Ni for qemu-devel@nongnu.org; Tue, 20 Dec 2016 05:40:26 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 301EA4E326 for ; Tue, 20 Dec 2016 10:40:24 +0000 (UTC) References: <1480980749-182204-1-git-send-email-imammedo@redhat.com> <1480980749-182204-2-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: Date: Tue, 20 Dec 2016 12:40:21 +0200 MIME-Version: 1.0 In-Reply-To: <1480980749-182204-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.9 01/10] tests: pc: add memory hotplug acpi tables tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Eduardo Habkost On 12/06/2016 01:32 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > tests/bios-tables-test.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 812f830..5404805 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -867,6 +867,28 @@ static void test_acpi_piix4_tcg_ipmi(void) > free_test_data(&data); > } > Hi Igor, > +static void test_acpi_q35_tcg_memhp(void) > +{ > + test_data data; > + > + memset(&data, 0, sizeof(data)); > + data.machine = MACHINE_Q35; > + data.variant = ".memhp"; > + test_acpi_one(" -m 128,slots=3,maxmem=1G -numa node", &data); Why do we need the "-numa node" ? (I am sure you put it there for a reason, but I don't know it :)) Thanks, Marcel > + free_test_data(&data); > +} > + > +static void test_acpi_piix4_tcg_memhp(void) > +{ > + test_data data; > + > + memset(&data, 0, sizeof(data)); > + data.machine = MACHINE_PC; > + data.variant = ".memhp"; > + test_acpi_one(" -m 128,slots=3,maxmem=1G -numa node", &data); > + free_test_data(&data); > +} > + > int main(int argc, char *argv[]) > { > const char *arch = qtest_get_arch(); > @@ -887,6 +909,8 @@ int main(int argc, char *argv[]) > qtest_add_func("acpi/q35/ipmi", test_acpi_q35_tcg_ipmi); > qtest_add_func("acpi/piix4/cpuhp", test_acpi_piix4_tcg_cphp); > qtest_add_func("acpi/q35/cpuhp", test_acpi_q35_tcg_cphp); > + qtest_add_func("acpi/piix4/memhp", test_acpi_piix4_tcg_memhp); > + qtest_add_func("acpi/q35/memhp", test_acpi_q35_tcg_memhp); > } > ret = g_test_run(); > boot_sector_cleanup(disk); >