From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94FC9C433DB for ; Wed, 20 Jan 2021 13:53:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2049223340 for ; Wed, 20 Jan 2021 13:53:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2049223340 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2Dv1-0007MI-VS for qemu-devel@archiver.kernel.org; Wed, 20 Jan 2021 08:53:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2Dsh-0006fT-Aa for qemu-devel@nongnu.org; Wed, 20 Jan 2021 08:50:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:43089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2Dsd-00033j-Ob for qemu-devel@nongnu.org; Wed, 20 Jan 2021 08:50:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611150637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=72BpfcQSRzdsOU5e9KhfiEHHK5oGfEhHlwaY2f3jNU0=; b=BFOht3eEmAFoBYu8vd/iKoWz0w5xseUbWotTnvc3ikXRThAb4ea2Reb0Yynuyk3QqXMBFL T4qPqR/7aug3bEzzcmre7sQ2aCM8s1wKJYQF01efGnmKYuKE1sEIBOMLVrJV1GyWXpAoL7 Wc/1K1OsJxG0Mc4UxU6iCw1ijUlJUY4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-M0ZCBFuOMDmwKadsa9Ymdw-1; Wed, 20 Jan 2021 08:50:35 -0500 X-MC-Unique: M0ZCBFuOMDmwKadsa9Ymdw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E25B580666F; Wed, 20 Jan 2021 13:50:33 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-114-178.ams2.redhat.com [10.36.114.178]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C9DB5D75A; Wed, 20 Jan 2021 13:50:31 +0000 (UTC) Subject: Re: [PATCH v4 00/23] backup performance: block_status + async From: Max Reitz To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20210116214705.822267-1-vsementsov@virtuozzo.com> <3a5ea1b1-1137-4ac5-5aac-5bdec0b7b0d5@redhat.com> <29cccc86-a450-3326-2d70-f3022e32b5db@redhat.com> Message-ID: Date: Wed, 20 Jan 2021 14:50:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <29cccc86-a450-3326-2d70-f3022e32b5db@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, wencongyang2@huawei.com, xiechanglong.d@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, den@openvz.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 20.01.21 11:39, Max Reitz wrote: > On 19.01.21 20:22, Vladimir Sementsov-Ogievskiy wrote: >> 19.01.2021 21:40, Max Reitz wrote: >>> On 16.01.21 22:46, Vladimir Sementsov-Ogievskiy wrote: >>>> Hi Max! >>>> I applied my series onto yours 129-fixing and found, that 129 fails >>>> for backup. >>>> And setting small max-chunk and even max-workers to 1 doesn't help! >>>> (setting >>>> speed like in v3 still helps). >>>> >>>> And I found, that the problem is that really, the whole backup job >>>> goes during >>>> drain, because in new architecture we do just job_yield() during the >>>> whole >>>> background block-copy. >>>> >>>> This leads to modifying the existing patch in the series, which does >>>> job_enter() >>>> from job_user_pause: we just need call job_enter() from job_pause() >>>> to cover >>>> not only user pauses but also drained_begin. >>>> >>>> So, now I don't need any additional fixing of 129. >>>> >>>> Changes in v4: >>>> - add a lot of Max's r-b's, thanks! >>>> >>>> 03: fix over-80 line (in comment), add r-b >>>> 09: was "[PATCH v3 10/25] job: call job_enter from job_user_pause", >>>>      now changed to finally fix 129 iotest, drop r-b >>>> >>>> 10: squash-in additional wording on max-chunk, fix error message, >>>> keep r-b >>>> 17: drop extra include, assert job_is_cancelled() instead of check, >>>> add r-b >>>> 18: adjust commit message, add r-b >>>> 23: add comments and assertion, about the fact that test doesn't >>>> support >>>>      paths with colon inside >>>>      fix s/disable-copy-range/use-copy-range/ >>> >>> Hmmm, for me, 129 sometimes fails still, because it completes too >>> quickly...  (The error then is that 'return[0]' does not exist in >>> query-block-jobs’s result, because the job is already gone.) >>> >>> When I insert a print(result) after the query-block-jobs, I can see >>> that the job has always progressed really far, even if its still >>> running. (Like, generally the offset is just one MB shy of 1G.) >>> >>> I suspect the problem is that block-copy just copies too much from >>> the start (by default); i.e., it starts 64 workers with, hm, well, 1 >>> MB of chunk size?  Shouldn’t fill the 128 MB immediately... >>> >>> Anyway, limiting the number of workers (to 1) and the chunk size (to >>> 64k) with x-perf does ensure that the backup job’s progress is >>> limited to 1 MB or so, which looks fine to me. >>> >>> I suppose we should do that, then (in 129), before patch 17? >> >> Yes, that sounds reasonable >> >>> >>> (PS: I can also see a MacOS failure in iotest 256.  I suspect it’s >>> related to this series, because 256 is a backup test (with >>> iothreads), but I’m not sure yet.  The log is here: >>> >>> https://cirrus-ci.com/task/5276331753603072 >>> ) >>> >> >> qemu received signal 31 ? >> >> googling for MacOS... >> >>   31    SIGUSR2      terminate process    User defined signal 2 > > coroutine-sigaltstack uses SIGUSR2 to set up new coroutines.  Perhaps > it’s unrelated to backup?  Guess I’ll just run the test one more time. O:) I ran it again, got the same error. There is no error on master, or before backup uses block_copy. I’m trying to run a test directly on the “move to block-copy” commit, but so far Cirrus doesn’t seem to want me to do another test run right now. (Though I’m pretty sure if there is no error before the block-copy commit, then using block-copy must be the problem. The remaining patches in my block branch are just disabling copy_range, some clean-up, the simplebench patches, the locking code error reporting change, and a new iotest.) Max