Re: [Qemu-devel] [PATCH] s390-pci: fix compilation on older GCC versions

[Christian Borntraeger <borntraeger@de.ibm.com>]

On 01/27/2017 02:20 PM, Paolo Bonzini wrote:
> S390PCIBusDevice is typedef'ed earlier in the file, before the hunks
> that this patch modifies.  The double typedef causes old versions of
> GCC to complain.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/s390x/s390-pci-bus.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/s390x/s390-pci-bus.h b/hw/s390x/s390-pci-bus.h
> index b0adefa..a25e926 100644
> --- a/hw/s390x/s390-pci-bus.h
> +++ b/hw/s390x/s390-pci-bus.h
> @@ -279,7 +279,7 @@ typedef struct S390PCIIOMMUTable {
>      S390PCIIOMMU *iommu[PCI_SLOT_MAX];
>  } S390PCIIOMMUTable;
> 
> -typedef struct S390PCIBusDevice {
> +struct S390PCIBusDevice {
>      DeviceState qdev;
>      PCIDevice *pdev;
>      ZpciState state;
> @@ -301,7 +301,7 @@ typedef struct S390PCIBusDevice {
>      IndAddr *indicator;
>      QEMUTimer *release_timer;
>      QTAILQ_ENTRY(S390PCIBusDevice) link;
> -} S390PCIBusDevice;
> +};
> 
>  typedef struct S390PCIBus {
>      BusState qbus;
> 
We cannot move this before S390PCIIOMMUTable due to the cross
dependency and we need a forward declaration of the typedef, so
yet this makes sense.

applied to our tree.