From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39CD7C433E0 for ; Tue, 2 Feb 2021 22:17:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4FC964EDA for ; Tue, 2 Feb 2021 22:17:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4FC964EDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l73yw-0006Ol-Qn for qemu-devel@archiver.kernel.org; Tue, 02 Feb 2021 17:17:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l73xu-0005cB-Ub for qemu-devel@nongnu.org; Tue, 02 Feb 2021 17:16:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:40549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l73xr-0000KB-DF for qemu-devel@nongnu.org; Tue, 02 Feb 2021 17:16:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612304162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VcoS1Ti8II1QRPYYhf1hDi9a51gwG75SULBK0odEhbE=; b=KGWwyQ3uiYfGVHXplmBkY9LXAb5oKAtyljEbH7xm+cPCidAhfBmw3poK8tEugaodM2iYmj 0hj1pBfltGwX63XdaGgBEQTpc6x4L/fuTe5xGao4G8wcUfP0m+D5fMJasW2csCSJxOBvVg lzbBIIGPulZgyDJ9e8mUmv/yfxhWuF8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-164-uSSK1bkiNauyY-9CQO8nYQ-1; Tue, 02 Feb 2021 17:15:58 -0500 X-MC-Unique: uSSK1bkiNauyY-9CQO8nYQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3A8985EE60; Tue, 2 Feb 2021 22:15:56 +0000 (UTC) Received: from [10.3.112.103] (ovpn-112-103.phx2.redhat.com [10.3.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C646910016F5; Tue, 2 Feb 2021 22:15:52 +0000 (UTC) Subject: Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description To: Vladimir Sementsov-Ogievskiy , "Denis V. Lunev" , qemu-devel@nongnu.org, qemu-block@nongnu.org References: <20210128171313.2210947-1-den@openvz.org> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Tue, 2 Feb 2021 16:15:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.386, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.155, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > 28.01.2021 20:13, Denis V. Lunev wrote: >> Original specification says that l1 table size if 64 * l1_size, which >> is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes. >> Thus 64 is to be replaces with 8 as specification says about bytes. >> >> There is also minor tweak, field name is renamed from l1 to l1_table, >> which matches with the later text. >> >> Signed-off-by: Denis V. Lunev >> CC: Stefan Hajnoczi >> CC: Vladimir Sementsov-Ogievskiy > > Reviewed-by: Vladimir Sementsov-Ogievskiy > I saw the subject "dirty bitmap", and assumed it would go through my dirty bitmap tree. In reality, it's unrelated to the dirty bitmap code. Would an improved subject line help? >> --- >>   docs/interop/parallels.txt | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/docs/interop/parallels.txt b/docs/interop/parallels.txt >> index e9271eba5d..f15bf35bd1 100644 >> --- a/docs/interop/parallels.txt >> +++ b/docs/interop/parallels.txt >> @@ -208,7 +208,7 @@ of its data area are: >>     28 - 31:    l1_size >>                 The number of entries in the L1 table of the bitmap. >>   -  variable:   l1 (64 * l1_size bytes) >> +  variable:   l1_table (8 * l1_size bytes) >>                 L1 offset table (in bytes) > > I don't remember why this "(in bytes)" is here.. What in bytes? L1 table > size? But the described field is not L1 table size, but L1 table > itself.. It's not in bytes, it's just L1 table :) > > So, I'd also drop "(in bytes)" while being here. Or the whole line "L1 > offset table (in bytes)" altogether. > >>     A dirty bitmap is stored using a one-level structure for the >> mapping to host >> > > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org