From: Richard Henderson <richard.henderson@linaro.org>
To: Nicholas Piggin <npiggin@gmail.com>,
Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH v2 1/4] target/ppc: Fix lqarx to set cpu_reserve
Date: Sun, 4 Jun 2023 20:09:28 -0700 [thread overview]
Message-ID: <ccccffff-e5e1-f2dd-53c7-3d0d2fa0ff3d@linaro.org> (raw)
In-Reply-To: <20230605025445.161932-1-npiggin@gmail.com>
On 6/4/23 19:54, Nicholas Piggin wrote:
> lqarx does not set cpu_reserve, which causes stqcx. to never succeed.
>
> Cc:qemu-stable@nongnu.org
> Fixes: 94bf2658676 ("target/ppc: Use atomic load for LQ and LQARX")
> Fixes: 57b38ffd0c6 ("target/ppc: Use tcg_gen_qemu_{ld,st}_i128 for LQARX, LQ, STQ")
> Signed-off-by: Nicholas Piggin<npiggin@gmail.com>
> ---
> v2:
> - Fix bugs vs memory access fault [Richard]
>
> target/ppc/translate.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-06-05 3:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 2:54 [PATCH v2 1/4] target/ppc: Fix lqarx to set cpu_reserve Nicholas Piggin
2023-06-05 2:54 ` [PATCH v2 2/4] target/ppc: Ensure stcx size matches larx Nicholas Piggin
2023-06-05 13:42 ` Daniel Henrique Barboza
2023-06-05 2:54 ` [PATCH v2 3/4] target/ppc: Remove larx/stcx. memory barrier semantics Nicholas Piggin
2023-06-05 13:42 ` Daniel Henrique Barboza
2023-06-05 2:54 ` [PATCH v2 4/4] target/ppc: Rework store conditional to avoid branch Nicholas Piggin
2023-06-05 13:42 ` Daniel Henrique Barboza
2023-06-05 3:09 ` Richard Henderson [this message]
2023-06-05 13:42 ` [PATCH v2 1/4] target/ppc: Fix lqarx to set cpu_reserve Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccccffff-e5e1-f2dd-53c7-3d0d2fa0ff3d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=danielhb413@gmail.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).