qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [RFC PATCH 2/2] hw/mips/jazz: Remove confusing ifdef'ry
Date: Fri, 26 Feb 2021 14:21:23 -0800	[thread overview]
Message-ID: <ccd34d47-a9f7-be79-5086-4a33e2d092a7@linaro.org> (raw)
In-Reply-To: <20210226132723.3969650-3-f4bug@amsat.org>

On 2/26/21 5:27 AM, Philippe Mathieu-Daudé wrote:
> @@ -211,10 +209,8 @@ static void mips_jazz_init(MachineState *machine,
>       * memory region that catches all memory accesses, as we do on Malta.
>       */
>      cc = CPU_GET_CLASS(cpu);
> -#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY)
>      real_do_transaction_failed = cc->tcg_ops->do_transaction_failed;
>      cc->tcg_ops->do_transaction_failed = mips_jazz_do_transaction_failed;
> -#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */

Ah, I wondered what you were after with that first patch,
and this is it.

Series:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


  reply	other threads:[~2021-02-26 22:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 13:27 [RFC PATCH 0/2] hw/mips: Restrict emulated machines to TCG Philippe Mathieu-Daudé
2021-02-26 13:27 ` [RFC PATCH 1/2] hw/mips/meson: Restrict emulated machines to TCG accelerator Philippe Mathieu-Daudé
2021-02-26 13:27 ` [RFC PATCH 2/2] hw/mips/jazz: Remove confusing ifdef'ry Philippe Mathieu-Daudé
2021-02-26 22:21   ` Richard Henderson [this message]
2021-02-26 14:02 ` [RFC PATCH 0/2] hw/mips: Restrict emulated machines to TCG Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccd34d47-a9f7-be79-5086-4a33e2d092a7@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=cfontana@suse.de \
    --cc=f4bug@amsat.org \
    --cc=hpoussin@reactos.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).