From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: David Hildenbrand <david@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Alistair Francis <alistair@alistair23.me>,
Jianxian Wen <jianxian.wen@verisilicon.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Peter Xu <peterx@redhat.com>, qemu-arm <qemu-arm@nongnu.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC PATCH 6/6] memory: Have address_space_create() re-use global &address_space_memory
Date: Fri, 20 Aug 2021 09:17:22 +0200 [thread overview]
Message-ID: <ccdaacfb-4c3c-33c9-77b7-782a0be4fa58@redhat.com> (raw)
In-Reply-To: <20210820060703.njdj5pfa3lz66zjb@sirius.home.kraxel.org>
On 8/20/21 8:07 AM, Gerd Hoffmann wrote:
> Hi,
>
>> This also seems to me to be the tail wagging the dog. If we think
>> 'info mtree' has too much duplicate information (which it certainly
>> does) then we should make mtree_info() smarter about reducing that
>> duplication. Off the top of my head, we could change the code that
>> prints ASes to do something like:
>
>> qemu_printf("...same as address-space %s\n", name);
>
> Neat idea.
>
> Having 'info mtree' accept an (optional) 'name' parameter to pick an
> address space to be printed would be useful too.
Yeah, for now I am thinking of a match string (for my use cases):
(qemu) info mtree -a dma # all address spaces matching *dma*
prev parent reply other threads:[~2021-08-20 7:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 14:20 [PATCH 0/6] memory: Introduce address_space_create(), re-use &address_space_memory Philippe Mathieu-Daudé
2021-08-19 14:20 ` [PATCH 1/6] memory: Do not increase refcount on global system_memory region Philippe Mathieu-Daudé
2021-08-19 14:23 ` Peter Maydell
2021-08-19 14:20 ` [PATCH 2/6] memory: Introduce address_space_create() Philippe Mathieu-Daudé
2021-08-19 14:24 ` Peter Maydell
2021-08-19 14:36 ` Philippe Mathieu-Daudé
2021-08-19 14:20 ` [PATCH 3/6] memory: Have cpu_address_space_init() use address_space_create() Philippe Mathieu-Daudé
2021-08-19 14:20 ` [PATCH 4/6] hw/dma: Replace alloc() + address_space_init() by address_space_create() Philippe Mathieu-Daudé
2021-08-19 14:22 ` Peter Maydell
2021-08-19 14:32 ` Philippe Mathieu-Daudé
2021-08-19 14:38 ` Peter Maydell
2021-08-19 14:41 ` Philippe Mathieu-Daudé
2021-08-19 14:20 ` [PATCH 5/6] hw/usb: " Philippe Mathieu-Daudé
2021-08-19 14:20 ` [RFC PATCH 6/6] memory: Have address_space_create() re-use global &address_space_memory Philippe Mathieu-Daudé
2021-08-19 14:34 ` Peter Maydell
2021-08-19 14:41 ` Philippe Mathieu-Daudé
2021-08-20 6:07 ` Gerd Hoffmann
2021-08-20 7:17 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccdaacfb-4c3c-33c9-77b7-782a0be4fa58@redhat.com \
--to=philmd@redhat.com \
--cc=alistair@alistair23.me \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=jianxian.wen@verisilicon.com \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).