From: Thomas Huth <thuth@redhat.com>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v2 6/6] tests/qtest/migration: Add a test for the analyze-migration script
Date: Tue, 10 Oct 2023 09:11:32 +0200 [thread overview]
Message-ID: <ccde2106-9d71-4e59-38e4-4b042fc5943c@redhat.com> (raw)
In-Reply-To: <20231009184326.15777-7-farosas@suse.de>
On 09/10/2023 20.43, Fabiano Rosas wrote:
> Add a smoke test that migrates to a file and gives it to the
> script. It should catch the most annoying errors such as changes in
> the ram flags.
>
> After code has been merged it becomes way harder to figure out what is
> causing the script to fail, the person making the change is the most
> likely to know right away what the problem is.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> tests/qtest/meson.build | 2 ++
> tests/qtest/migration-test.c | 60 ++++++++++++++++++++++++++++++++++++
> 2 files changed, 62 insertions(+)
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-10-10 7:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 18:43 [PATCH v2 0/6] scripts/migration: Fix analyze-migration.py and add a test Fabiano Rosas
2023-10-09 18:43 ` [PATCH v2 1/6] migration: Add the configuration vmstate to the json writer Fabiano Rosas
2023-10-11 13:12 ` Juan Quintela
2023-10-11 13:33 ` Fabiano Rosas
2023-10-09 18:43 ` [PATCH v2 2/6] migration: Fix analyze-migration.py 'configuration' parsing Fabiano Rosas
2023-10-11 13:16 ` Juan Quintela
2023-10-09 18:43 ` [PATCH v2 3/6] migration: Add capability parsing to analyze-migration.py Fabiano Rosas
2023-10-11 13:22 ` Juan Quintela
2023-10-09 18:43 ` [PATCH v2 4/6] migration: Fix analyze-migration.py when ignore-shared is used Fabiano Rosas
2023-10-11 13:23 ` Juan Quintela
2023-10-11 13:32 ` Fabiano Rosas
2023-10-11 14:10 ` Juan Quintela
2023-10-09 18:43 ` [PATCH v2 5/6] migration: Fix analyze-migration read operation signedness Fabiano Rosas
2023-10-11 13:24 ` Juan Quintela
2023-10-09 18:43 ` [PATCH v2 6/6] tests/qtest/migration: Add a test for the analyze-migration script Fabiano Rosas
2023-10-10 7:11 ` Thomas Huth [this message]
2023-10-11 13:28 ` Juan Quintela
2023-10-11 13:35 ` Fabiano Rosas
2023-10-10 20:27 ` [PATCH v2 0/6] scripts/migration: Fix analyze-migration.py and add a test Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccde2106-9d71-4e59-38e4-4b042fc5943c@redhat.com \
--to=thuth@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).