qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: riku.voipio@linaro.org
To: qemu-devel@nongnu.org
Cc: John Rigby <john.rigby@linaro.org>
Subject: [Qemu-devel] [PATCH 03/11] linux-user/syscall.c: handle FUTEX_WAIT_BITSET in do_futex
Date: Mon, 11 Mar 2013 21:27:40 +0200	[thread overview]
Message-ID: <cce246e0a21577bb2372ab3a7d6789371e087de9.1363029059.git.riku.voipio@linaro.org> (raw)
In-Reply-To: <cover.1363029059.git.riku.voipio@linaro.org>

From: John Rigby <john.rigby@linaro.org>

Upstream libc has recently changed to start using
FUTEX_WAIT_BITSET instead of FUTEX_WAIT and this
is causing do_futex to return -TARGET_ENOSYS.

Pass bitset in val3 to sys_futex which will be
ignored by kernel for the FUTEX_WAIT case.

Signed-off-by: John Rigby <john.rigby@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 linux-user/syscall.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 19630ea..c7fcfc0 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -4922,6 +4922,7 @@ static int do_futex(target_ulong uaddr, int op, int val, target_ulong timeout,
 #endif
     switch (base_op) {
     case FUTEX_WAIT:
+    case FUTEX_WAIT_BITSET:
         if (timeout) {
             pts = &ts;
             target_to_host_timespec(pts, timeout);
@@ -4929,7 +4930,7 @@ static int do_futex(target_ulong uaddr, int op, int val, target_ulong timeout,
             pts = NULL;
         }
         return get_errno(sys_futex(g2h(uaddr), op, tswap32(val),
-                         pts, NULL, 0));
+                         pts, NULL, val3));
     case FUTEX_WAKE:
         return get_errno(sys_futex(g2h(uaddr), op, val, NULL, NULL, 0));
     case FUTEX_FD:
-- 
1.7.10.4

  parent reply	other threads:[~2013-03-11 19:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11 19:27 [Qemu-devel] [PULL] linux-user updates riku.voipio
2013-03-11 19:27 ` [Qemu-devel] [PATCH 01/11] linux-user: Add Alpha socket constants riku.voipio
2013-03-11 19:27 ` [Qemu-devel] [PATCH 02/11] linux-user: improve print_fcntl() riku.voipio
2013-03-11 19:27 ` riku.voipio [this message]
2013-03-11 19:27 ` [Qemu-devel] [PATCH 04/11] linux-user: fix futex strace of FUTEX_CLOCK_REALTIME riku.voipio
2013-03-11 19:27 ` [Qemu-devel] [PATCH 05/11] linux-user: Support setgroups syscall with no groups riku.voipio
2013-03-11 19:27 ` [Qemu-devel] [PATCH 06/11] linux-user: Add more sparc syscall numbers riku.voipio
2013-03-11 19:27 ` [Qemu-devel] [PATCH 07/11] linux-user: Fix layout of usage table to account for option text riku.voipio
2013-03-11 19:27 ` [Qemu-devel] [PATCH 08/11] linux-user: make bogus negative iovec lengths fail EINVAL riku.voipio
2013-03-11 19:27 ` [Qemu-devel] [PATCH 09/11] linux-user: Implement sendfile and sendfile64 riku.voipio
2013-03-11 19:27 ` [Qemu-devel] [PATCH 10/11] linux-user: Implement accept4 riku.voipio
2013-03-11 19:27 ` [Qemu-devel] [PATCH 11/11] linux-user/syscall.c: Don't warn about unimplemented get_robust_list riku.voipio
2013-03-11 21:21 ` [Qemu-devel] [PULL] linux-user updates Peter Maydell
2013-03-11 22:58   ` Anthony Liguori
2013-03-15 14:55 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cce246e0a21577bb2372ab3a7d6789371e087de9.1363029059.git.riku.voipio@linaro.org \
    --to=riku.voipio@linaro.org \
    --cc=john.rigby@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).