From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mreitz@redhat.com,
jsnow@redhat.com, den@openvz.org, peter.maydell@linaro.org,
berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/4] checkpatch: check trace-events code style
Date: Mon, 31 Jul 2017 07:48:41 -0500 [thread overview]
Message-ID: <cce442b5-c483-b6ea-e0cf-63005c0cb51c@redhat.com> (raw)
In-Reply-To: <20170731092606.GD11830@stefanha-x1.localdomain>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On 07/31/2017 04:26 AM, Stefan Hajnoczi wrote:
> On Sat, Jul 29, 2017 at 04:11:58PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> Accordingly to CODING_STYLE, check that in trace-events:
s/Accordingly/According/
>> 1. hex numbers are prefixed with '0x'
>> 2. '#' flag of printf is not used
>> 3. The exclusion from 1. are period-separated groups of numbers
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>> scripts/checkpatch.pl | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-07-31 12:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 13:11 [Qemu-devel] [PATCH v2 0/4] trace-events: print 0x before hex numbers Vladimir Sementsov-Ogievskiy
2017-07-29 13:11 ` [Qemu-devel] [PATCH v2 1/4] coding_style: add point about 0x in trace-events Vladimir Sementsov-Ogievskiy
2017-07-31 9:19 ` Stefan Hajnoczi
2017-07-31 12:45 ` Eric Blake
2017-07-29 13:11 ` [Qemu-devel] [PATCH v2 2/4] trace-events: fix code style: %# -> 0x% Vladimir Sementsov-Ogievskiy
2017-07-31 9:24 ` Stefan Hajnoczi
2017-07-31 12:48 ` Eric Blake
2017-07-29 13:11 ` [Qemu-devel] [PATCH v2 3/4] checkpatch: check trace-events code style Vladimir Sementsov-Ogievskiy
2017-07-31 9:26 ` Stefan Hajnoczi
2017-07-31 12:48 ` Eric Blake [this message]
2017-07-29 13:11 ` [Qemu-devel] [PATCH v2 4/4] trace-events: fix code style: print 0x before hex numbers Vladimir Sementsov-Ogievskiy
2017-07-31 9:36 ` Stefan Hajnoczi
2017-07-31 9:49 ` Cornelia Huck
2017-07-31 15:05 ` Vladimir Sementsov-Ogievskiy
2017-07-31 15:38 ` Cornelia Huck
2017-07-29 13:32 ` [Qemu-devel] [PATCH v2 0/4] trace-events: " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cce442b5-c483-b6ea-e0cf-63005c0cb51c@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).