From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 3/5] kvm: x86: Drop redundant apic base and tpr update from kvm_get_sregs
Date: Thu, 22 Dec 2011 18:13:48 -0200 [thread overview]
Message-ID: <cce47516cddfb886da9a03cb9db355958b890dce.1324584830.git.mtosatti@redhat.com> (raw)
In-Reply-To: <cover.1324584830.git.mtosatti@redhat.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
The latter was already commented out, the former is redundant as well.
We always get the latest changes after return from the guest via
kvm_arch_post_run.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
target-i386/kvm.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 06f4401..d206852 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -1082,10 +1082,9 @@ static int kvm_get_sregs(CPUState *env)
env->cr[3] = sregs.cr3;
env->cr[4] = sregs.cr4;
- cpu_set_apic_base(env->apic_state, sregs.apic_base);
-
env->efer = sregs.efer;
- //cpu_set_apic_tpr(env->apic_state, sregs.cr8);
+
+ /* changes to apic base and cr8/tpr are read back via kvm_arch_post_run */
#define HFLAG_COPY_MASK \
~( HF_CPL_MASK | HF_PE_MASK | HF_MP_MASK | HF_EM_MASK | \
--
1.7.6.4
next prev parent reply other threads:[~2011-12-22 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 20:13 [Qemu-devel] [PATCH 0/5] [PULL] qemu-kvm.git uq/master queue Marcelo Tosatti
2011-12-22 20:13 ` [Qemu-devel] [PATCH 1/5] kvm: x86: Use symbols for all xsave field Marcelo Tosatti
2011-12-22 20:13 ` [Qemu-devel] [PATCH 2/5] kvm: x86: Avoid runtime allocation of xsave buffer Marcelo Tosatti
2011-12-22 20:13 ` Marcelo Tosatti [this message]
2011-12-22 20:13 ` [Qemu-devel] [PATCH 4/5] Set numa topology for max_cpus Marcelo Tosatti
2011-12-22 20:13 ` [Qemu-devel] [PATCH 5/5] enable architectural PMU cpuid leaf for kvm Marcelo Tosatti
2011-12-27 16:36 ` [Qemu-devel] [PATCH 0/5] [PULL] qemu-kvm.git uq/master queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cce47516cddfb886da9a03cb9db355958b890dce.1324584830.git.mtosatti@redhat.com \
--to=mtosatti@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).