From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, armbru@redhat.com
Subject: Re: [PATCH v2 2/3] hw/display: Allow vga_common_init() to return errors
Date: Thu, 17 Mar 2022 12:19:32 +0100 [thread overview]
Message-ID: <cceefe62-2836-a364-b19f-a63f750f5de9@gmail.com> (raw)
In-Reply-To: <20220317083027.16688-3-thuth@redhat.com>
On 17/3/22 09:30, Thomas Huth wrote:
> The vga_common_init() function currently cannot report errors to its
> caller. But in the following patch, we'd need this possibility, so
> let's change it to take an "Error **" as parameter for this.
Thanks for updating to return a boolean.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/display/vga_int.h | 2 +-
> hw/display/ati.c | 4 +++-
> hw/display/cirrus_vga.c | 4 +++-
> hw/display/cirrus_vga_isa.c | 4 +++-
> hw/display/qxl.c | 6 +++++-
> hw/display/vga-isa.c | 5 ++++-
> hw/display/vga-mmio.c | 5 ++++-
> hw/display/vga-pci.c | 8 ++++++--
> hw/display/vga.c | 11 +++++++++--
> hw/display/virtio-vga.c | 4 +++-
> hw/display/vmware_vga.c | 2 +-
> 11 files changed, 42 insertions(+), 13 deletions(-)
next prev parent reply other threads:[~2022-03-17 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 8:30 [PATCH v2 0/3] Fix crash when adding a second ISA VGA device Thomas Huth
2022-03-17 8:30 ` [PATCH v2 1/3] hw/display/cirrus_vga: Clean up indentation in pci_cirrus_vga_realize() Thomas Huth
2022-03-17 8:30 ` [PATCH v2 2/3] hw/display: Allow vga_common_init() to return errors Thomas Huth
2022-03-17 11:19 ` Philippe Mathieu-Daudé [this message]
2022-03-17 8:30 ` [PATCH v2 3/3] hw/display/vga: Report a proper error when adding a 2nd ISA VGA Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cceefe62-2836-a364-b19f-a63f750f5de9@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).