From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/4] hw/core/loader.c: Track last-seen ROM in rom_check_and_register_reset()
Date: Mon, 30 Nov 2020 12:23:56 -0600 [thread overview]
Message-ID: <ccf1e36e-f6d5-28e6-c90e-40927723f842@linaro.org> (raw)
In-Reply-To: <20201129203923.10622-2-peter.maydell@linaro.org>
On 11/29/20 2:39 PM, Peter Maydell wrote:
> In rom_check_and_register_reset() we detect overlaps by looking at
> whether the ROM blob we're currently examining is in the same address
> space and starts before the previous ROM blob ends. (This works
> because the ROM list is kept sorted in order by AddressSpace and then
> by address.)
>
> Instead of keeping the AddressSpace and last address of the previous ROM
> blob in local variables, just keep a pointer to it.
>
> This will allow us to print more useful information when we do detect
> an overlap.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/core/loader.c | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-11-30 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 20:39 [PATCH 0/4] Improve reporting of ROM blob overlap errors Peter Maydell
2020-11-29 20:39 ` [PATCH 1/4] hw/core/loader.c: Track last-seen ROM in rom_check_and_register_reset() Peter Maydell
2020-11-30 18:23 ` Richard Henderson [this message]
2020-11-29 20:39 ` [PATCH 2/4] hw/core/loader.c: Improve reporting of ROM overlap errors Peter Maydell
2020-11-30 18:26 ` Richard Henderson
2020-11-29 20:39 ` [PATCH 3/4] elf_ops.h: Don't truncate name of the ROM blobs we create Peter Maydell
2020-11-30 18:26 ` Richard Henderson
2020-11-29 20:39 ` [PATCH 4/4] elf_ops.h: Be more verbose with ROM blob names Peter Maydell
2020-11-30 18:27 ` Richard Henderson
2020-12-11 14:08 ` [PATCH 0/4] Improve reporting of ROM blob overlap errors Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccf1e36e-f6d5-28e6-c90e-40927723f842@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).