From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ABA6C07E9B for ; Wed, 21 Jul 2021 07:09:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 824F7601FC for ; Wed, 21 Jul 2021 07:09:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 824F7601FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m66MU-0005yQ-Hf for qemu-devel@archiver.kernel.org; Wed, 21 Jul 2021 03:09:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m66Ls-0005Jp-6Z for qemu-devel@nongnu.org; Wed, 21 Jul 2021 03:09:08 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:39736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m66Lq-00022x-HY for qemu-devel@nongnu.org; Wed, 21 Jul 2021 03:09:07 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 42B5D1FE77; Wed, 21 Jul 2021 07:09:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626851343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZuPd8DaDsQXC9Suf8ld+kjNJcFHJLX+O9uvCElox+9Q=; b=zPGf9rlDqcwwsVA57rz/FbiS87Adp+CX5m20gYq3I65NkOr/2nNpQe7NIScmKySWS+s0nk RjrRGxjNg9uM9Drx9Qg0j/Le0bomxIg1B++vrsSSp2XTBswGiWeTbRSuY9RVlmjhlRArRr s+vN9YiLYS5JM4C+0MglkNy0U79yiuo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626851343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZuPd8DaDsQXC9Suf8ld+kjNJcFHJLX+O9uvCElox+9Q=; b=A0W0rmRV8bl/woZkOa8lzTwteYzYW6QFh2f52+HFwMj460WEQ6foyxE39ZCvJrlmOek/+6 zSWs4rDYk8AjWUDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E84A913A66; Wed, 21 Jul 2021 07:09:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id x4M1Ng7I92BnegAAMHmgww (envelope-from ); Wed, 21 Jul 2021 07:09:02 +0000 Subject: Re: [PATCH 2/2] qom: Improve error message in module_object_class_by_name() To: "Jose R. Ziviani" , qemu-devel@nongnu.org References: <20210720223120.21711-1-jziviani@suse.de> <20210720223120.21711-3-jziviani@suse.de> From: Claudio Fontana Message-ID: Date: Wed, 21 Jul 2021 09:09:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210720223120.21711-3-jziviani@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.29; envelope-from=cfontana@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, richard.henderson@linaro.org, berrange@redhat.com, kraxel@redhat.com, ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/21/21 12:31 AM, Jose R. Ziviani wrote: > module_object_class_by_name() calls module_load_qom_one if the object > is provided by a dynamically linked library. Such library might not be > available at this moment - for instance, it can be a package not yet > installed. Thus, instead of assert error messages, this patch outputs > more friendly messages. > > Current error messages: > $ ./qemu-system-x86_64 -machine q35 -accel tcg -kernel /boot/vmlinuz > ... > ERROR:../accel/accel-softmmu.c:82:accel_init_ops_interfaces: assertion failed: (ops != NULL) > Bail out! ERROR:../accel/accel-softmmu.c:82:accel_init_ops_interfaces: assertion failed: (ops != NULL) > [1] 31964 IOT instruction (core dumped) ./qemu-system-x86_64 ... > > New error message: > $ ./qemu-system-x86_64 -machine q35 -accel tcg -kernel /boot/vmlinuz > accel-tcg-x86_64 module is missing, install the package or config the library path correctly. > > Or with other modules, when possible: > $ ./qemu-system-x86_64 -machine q35 -accel kvm -kernel /boot/vmlinuz -vga qxl ✹ > hw-display-qxl module is missing, install the package or config the library path correctly. > qemu-system-x86_64: QXL VGA not available > > $ make check > ... > Running test qtest-x86_64/test-filter-mirror > Running test qtest-x86_64/endianness-test > accel-qtest-x86_64 module is missing, install the package or config the library path correctly. > accel-qtest-x86_64 module is missing, install the package or config the library path correctly. > accel-qtest-x86_64 module is missing, install the package or config the library path correctly. > accel-qtest-x86_64 module is missing, install the package or config the library path correctly. > accel-qtest-x86_64 module is missing, install the package or config the library path correctly. > accel-tcg-x86_64 module is missing, install the package or config the library path correctly. > ... > > Signed-off-by: Jose R. Ziviani > --- > accel/accel-softmmu.c | 5 ++++- > qom/object.c | 9 +++++++++ > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/accel/accel-softmmu.c b/accel/accel-softmmu.c > index 67276e4f52..52449ac2d0 100644 > --- a/accel/accel-softmmu.c > +++ b/accel/accel-softmmu.c > @@ -79,7 +79,10 @@ void accel_init_ops_interfaces(AccelClass *ac) > * all accelerators need to define ops, providing at least a mandatory > * non-NULL create_vcpu_thread operation. > */ > - g_assert(ops != NULL); > + if (ops == NULL) { > + exit(1); > + } > + Why? > if (ops->ops_init) { > ops->ops_init(ops); > } > diff --git a/qom/object.c b/qom/object.c > index 6a01d56546..3a170ea9df 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -10,6 +10,7 @@ > * See the COPYING file in the top-level directory. > */ > > +#include "qemu/module.h" > #include "qemu/osdep.h" > #include "hw/qdev-core.h" > #include "qapi/error.h" > @@ -1031,8 +1032,16 @@ ObjectClass *module_object_class_by_name(const char *typename) > oc = object_class_by_name(typename); > #ifdef CONFIG_MODULES > if (!oc) { > + const char *module_name = module_get_name_from_obj(typename); > module_load_qom_one(typename); > oc = object_class_by_name(typename); > + if (!oc && module_name) { > + if (!module_is_loaded(module_name)) { > + fprintf(stderr, "%s module is missing, install the " > + "package or config the library path " > + "correctly.\n", module_name); > + } > + } > } > #endif > return oc; >