From: Paolo Bonzini <pbonzini@redhat.com>
To: Yang Zhong <yang.zhong@intel.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Maydell, Peter" <peter.maydell@linaro.org>,
thuth@redhat.com, ehabkost@redhat.com, qemu-devel@nongnu.org,
sameo@linux.intel.com
Subject: Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable
Date: Mon, 21 Jan 2019 12:54:53 +0100 [thread overview]
Message-ID: <ccfff9f3-e3db-d6a8-dbeb-b5fbda731393@redhat.com> (raw)
In-Reply-To: <20190121112651.GA19350@yangzhon-Virtual>
On 21/01/19 12:26, Yang Zhong wrote:
> On Mon, Jan 21, 2019 at 11:25:57AM +0100, Paolo Bonzini wrote:
>> On 18/01/19 20:28, Michael S. Tsirkin wrote:
>>> OK, and I also think we should rename it PCIE -> PCI_EXPRESS_, this way
>>> everything PCI starts with PCI.
>>
>> I have no preference for PCIE vs. PCI_EXPRESS (PCIE is universally known
>> and shorter, but it's okay either way), but I agree it makes sense to
>> rename everything that selects PCIE so that it starts with either PCIE
>> or PCI_EXPRESS. Yang, can you place a patch to do that before your
>> series to do the rename?
>>
> Hello Paolo,
>
> Yes, i can change PCIE to PCI_EXPRESS per Michael's comments. How can i share
> this patch ?, or i will send this patches with another changes(patch 41) in v4 ? thanks!
You can place it as patch 1 in v4.
Paolo
next prev parent reply other threads:[~2019-01-21 12:02 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 11:23 [Qemu-devel] [RFC PATCH v3 00/43] Support Kconfig in QEMU Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 01/43] build: actually use CONFIG_PAM Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 02/43] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 03/43] hw/arm/Makefile.objs: CONFIG_VIRT created for virt board Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 04/43] hw/m68k/Makefile.objs: Conditionally build boards Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 05/43] hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 06/43] hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 07/43] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_* Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 08/43] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 09/43] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 10/43] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 11/43] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 12/43] hw/nios2/Makefile.objs: Conditionally build nios2 Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 13/43] hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 14/43] hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64 Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 15/43] hw/alpha/Makefile.objs: Create CONFIG_* for alpha Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 16/43] hw/cris/Makefile.objs: Create CONFIG_* for cris Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 17/43] hw/hppa/Makefile.objs: Create CONFIG_* for hppa Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 18/43] hw/moxie/Makefile.objs: Conditionally build moxie Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 19/43] hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 20/43] hw/tricore/Makefile.objs: Create CONFIG_* for tricore Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 21/43] minikconfig: add parser skeleton Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 22/43] minikconfig: add AST Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 23/43] minikconfig: add semantic analysis Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 24/43] hw/display: make edid configurable Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 25/43] kconfig: introduce kconfig files Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 26/43] build: switch to Kconfig Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 27/43] ide: express dependencies with Kconfig Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable Yang Zhong
2019-01-18 16:33 ` Michael S. Tsirkin
2019-01-18 17:28 ` Paolo Bonzini
2019-01-18 19:28 ` Michael S. Tsirkin
2019-01-21 10:25 ` Paolo Bonzini
2019-01-21 11:26 ` Yang Zhong
2019-01-21 11:54 ` Paolo Bonzini [this message]
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 29/43] build: convert pci.mak to Kconfig Yang Zhong
2019-01-18 16:36 ` Michael S. Tsirkin
2019-01-18 17:03 ` Paolo Bonzini
2019-01-18 19:21 ` Michael S. Tsirkin
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 30/43] build: convert sound.mak " Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 31/43] build: convert usb.mak " Yang Zhong
2019-01-18 11:23 ` [Qemu-devel] [RFC PATCH v3 32/43] scsi: express dependencies with Kconfig Yang Zhong
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 33/43] bluetooth: " Yang Zhong
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 34/43] isa: express dependencies with kconfig Yang Zhong
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 35/43] i386: express dependencies with Kconfig Yang Zhong
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 36/43] i2c: " Yang Zhong
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 37/43] ptimer: " Yang Zhong
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 38/43] edid: express dependencies with kconfig Yang Zhong
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 39/43] hyperv: " Yang Zhong
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 40/43] virtio: make virtio dependencies with Kconfig Yang Zhong
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 41/43] i386-softmmu.mak: remove all CONFIG_* except boards definitions Yang Zhong
2019-01-18 15:28 ` Paolo Bonzini
2019-01-18 15:37 ` Thomas Huth
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 42/43] minikconf: implement allyesconfig, allnoconfig, randconfig, defconfig Yang Zhong
2019-01-18 11:24 ` [Qemu-devel] [RFC PATCH v3 43/43] Makefile: only support defconfig Yang Zhong
2019-01-18 16:30 ` [Qemu-devel] [RFC PATCH v3 00/43] Support Kconfig in QEMU Michael S. Tsirkin
2019-01-18 16:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccfff9f3-e3db-d6a8-dbeb-b5fbda731393@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sameo@linux.intel.com \
--cc=thuth@redhat.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).