qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: David Brenken <david.brenken@efs-auto.org>, qemu-devel@nongnu.org
Cc: Andreas Konopik <andreas.konopik@efs-auto.de>,
	David Brenken <david.brenken@efs-auto.de>,
	Robert Rasche <robert.rasche@efs-auto.de>,
	Georg Hofstetter <georg.hofstetter@efs-auto.de>,
	Lars Biermanski <lars.biermanski@efs-auto.de>
Subject: Re: [Qemu-devel] [PATCH v2 4/5] tricore: add QSEED instruction
Date: Wed, 19 Jun 2019 14:25:14 +0200	[thread overview]
Message-ID: <cd1adeb4-6006-fcc8-4301-0604623f3991@mail.uni-paderborn.de> (raw)
In-Reply-To: <20190619075643.10048-5-david.brenken@efs-auto.org>


On 6/19/19 9:56 AM, David Brenken wrote:
> +
> +        result = 0;
> +        result = deposit32(result, 31, 1, new_S);
> +        result = deposit32(result, 23, 8, new_E);
> +        result = deposit32(result, 15, 8, new_M);
> +    }
> +
> +    if (float32_is_any_nan(arg1) || result == float32_sqrt_nan) {


You need float32_is_signaling_nan, since only signaling nan raises the 
invalid flag.


> +        env->FPU_FI = 1;

env->FPU_FI = 1 << 31;

See f_update_psw_flags(). FPU_FI  and PSW_V are the same and we defined 
bit 31 as the V bit for optimization purposes.

Cheers,

Bastian



  reply	other threads:[~2019-06-19 12:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-19  7:56 [Qemu-devel] [PATCH v2 0/5] tricore: adding new instructions and fixing issues David Brenken
2019-06-19  7:56 ` [Qemu-devel] [PATCH v2 1/5] tricore: add FTOIZ instruction David Brenken
2019-06-19  7:56 ` [Qemu-devel] [PATCH v2 2/5] tricore: add UTOF instruction David Brenken
2019-06-19  7:56 ` [Qemu-devel] [PATCH v2 3/5] tricore: fix RRPW_INSERT instruction David Brenken
2019-06-19  9:10   ` Bastian Koppelmann
2019-06-19  7:56 ` [Qemu-devel] [PATCH v2 4/5] tricore: add QSEED instruction David Brenken
2019-06-19 12:25   ` Bastian Koppelmann [this message]
2019-06-21 10:55     ` Konopik, Andreas (EFS-GH2)
2019-06-19  7:56 ` [Qemu-devel] [PATCH v2 5/5] tricore: reset DisasContext before generating code David Brenken
2019-06-19 12:25   ` Bastian Koppelmann
2019-06-19 12:41     ` Brenken, David (EFS-GH2)
2019-06-19  8:27 ` [Qemu-devel] [PATCH v2 0/5] tricore: adding new instructions and fixing issues no-reply
2019-06-19  8:33 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd1adeb4-6006-fcc8-4301-0604623f3991@mail.uni-paderborn.de \
    --to=kbastian@mail.uni-paderborn.de \
    --cc=andreas.konopik@efs-auto.de \
    --cc=david.brenken@efs-auto.de \
    --cc=david.brenken@efs-auto.org \
    --cc=georg.hofstetter@efs-auto.de \
    --cc=lars.biermanski@efs-auto.de \
    --cc=qemu-devel@nongnu.org \
    --cc=robert.rasche@efs-auto.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).