From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: "Philippe Mathieu-Daudé " <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Philippe Mathieu-Daudé " <philmd@linaro.org>,
qemu-stable@nongnu.org
Subject: Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one
Date: Mon, 22 Apr 2024 23:10:51 +0300 [thread overview]
Message-ID: <cd1r5.n1iglebry01@linaro.org> (raw)
In-Reply-To: <20240422142056.3023-1-philmd@linaro.org>
On Mon, 22 Apr 2024 17:20, Philippe Mathieu-Daudé <philmd@linaro.org>
wrote:
>Since VirtIO devices can change endianness at runtime,
>we need to use the device endianness, not the target
>one.
>
>Cc: qemu-stable@nongnu.org
>Fixes: eb9ad377bb ("virtio-sound: handle control messages and streams")
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>---
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Thanks for the explanation on v2 btw. virtio_is_big_endian()'s doc
should probably reflect it's not just about legacy devices (virtio sound
isn't legacy) but about target originating data streams too
next prev parent reply other threads:[~2024-04-22 20:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 14:20 [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one Philippe Mathieu-Daudé
2024-04-22 20:10 ` Manos Pitsidianakis [this message]
2024-04-22 21:02 ` Michael S. Tsirkin
2024-04-22 21:07 ` Philippe Mathieu-Daudé
2024-04-22 21:11 ` Michael S. Tsirkin
2024-04-23 8:47 ` Manos Pitsidianakis
2024-04-23 9:18 ` Manos Pitsidianakis
2024-04-23 11:05 ` Philippe Mathieu-Daudé
2024-04-24 10:31 ` Mark Cave-Ayland
2024-04-25 6:30 ` Manos Pitsidianakis
2024-04-25 7:49 ` Mark Cave-Ayland
2024-04-25 10:04 ` Manos Pitsidianakis
2024-04-25 10:24 ` Michael S. Tsirkin
2024-04-25 10:26 ` Manos Pitsidianakis
2024-04-25 10:31 ` Michael S. Tsirkin
2024-04-25 10:40 ` Mark Cave-Ayland
2024-04-25 11:15 ` Philippe Mathieu-Daudé
2024-04-25 11:46 ` Michael S. Tsirkin
2024-04-25 10:35 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd1r5.n1iglebry01@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).