From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Natanael Copa" <ncopa@alpinelinux.org>,
qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] util: fix build with musl libc on ppc64le
Date: Tue, 9 Jan 2024 08:13:55 +1100 [thread overview]
Message-ID: <cd2f9cb8-9f79-438e-8ca8-a3bf1675b232@linaro.org> (raw)
In-Reply-To: <5f7b5921-b6e3-48f1-8bec-b4fdbfdac2f1@linaro.org>
On 1/5/24 03:26, Philippe Mathieu-Daudé wrote:
> Hi Natanael,
>
> On 19/12/23 11:51, Natanael Copa wrote:
>> Use PPC_FEATURE2_ISEL and PPC_FEATURE2_VEC_CRYPTO from linux headers
>> instead of the GNU specific PPC_FEATURE2_HAS_ISEL and
>> PPC_FEATURE2_HAS_VEC_CRYPTO. This fixes build with musl libc.
>>
>> Fixes: 623d7e3551a6 (util: Add cpuinfo-ppc.c)
>
> Hmm this commit barely moved the code. Maybe it revealed the
> issue from the following commits?
>
> Fixes: 63922f467a ("tcg/ppc: Replace HAVE_ISEL macro with a variable")
> Fixes: 68f340d4cd ("tcg/ppc: Enable Altivec detection")
>
> Anyhow, changes LGTM.
Queued, thanks.
r~
prev parent reply other threads:[~2024-01-08 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 10:51 [PATCH] util: fix build with musl libc on ppc64le Natanael Copa
2024-01-04 16:26 ` Philippe Mathieu-Daudé
2024-01-08 21:13 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd2f9cb8-9f79-438e-8ca8-a3bf1675b232@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ncopa@alpinelinux.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).