qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: George Kennedy <george.kennedy@oracle.com>,
	famz@redhat.com, qemu-devel@nongnu.org,
	boris.ostrovsky@oracle.com
Subject: Re: [Qemu-devel] [PATCH v5] lsi: Reselection needed to remove pending commands from queue
Date: Wed, 7 Nov 2018 18:37:52 +0100	[thread overview]
Message-ID: <cd38afdb-2f45-3f87-90c5-8a8b08fa5354@redhat.com> (raw)
In-Reply-To: <1541607585-15570-1-git-send-email-george.kennedy@oracle.com>

On 07/11/2018 17:19, George Kennedy wrote:
> +                if (s->want_resel && s->resel_dsp) {
> +                    save_dsp = s->dsp;
> +                    s->dsp = s->resel_dsp;
> +                    s->want_resel = false;
> +                }
>                  break;

Almost... this should be in lsi_reselect, and should be replaced by a
call to lsi_reselect.

Paolo

      reply	other threads:[~2018-11-07 17:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 16:19 [Qemu-devel] [PATCH v5] lsi: Reselection needed to remove pending commands from queue George Kennedy
2018-11-07 17:37 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd38afdb-2f45-3f87-90c5-8a8b08fa5354@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=famz@redhat.com \
    --cc=george.kennedy@oracle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).