From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, berto@igalia.com, pavel.dovgaluk@ispras.ru,
qemu-devel@nongnu.org, armbru@redhat.com,
Greg Kurz <groug@kaod.org>,
stefanha@redhat.com, pbonzini@redhat.com, mreitz@redhat.com,
jsnow@redhat.com, ari@tuxera.com
Subject: Re: [PATCH v7 13/14] block/qed: bdrv_qed_do_open: deal with errp
Date: Fri, 12 Feb 2021 16:18:50 -0600 [thread overview]
Message-ID: <cd3a8b99-99d6-96e8-3a0b-0ec6930cdc55@redhat.com> (raw)
In-Reply-To: <20210202124956.63146-14-vsementsov@virtuozzo.com>
On 2/2/21 6:49 AM, Vladimir Sementsov-Ogievskiy wrote:
> Set errp always on failure. Generic bdrv_open_driver supports driver
> functions which can return negative value and forget to set errp.
> That's a strange thing.. Let's improve bdrv_qed_do_open to not behave
> this way. This allows to simplify code in
> bdrv_qed_co_invalidate_cache().
Grammar tweak:
Always set errp on failure. Generic bdrv_open_driver supports driver
functions which can return a negative value but forget to set errp.
That's a strange thing. Let's improve bdrv_qed_do_open to not behave
this way. This allows the simplification of code in
bdrv_qed_co_invalidate_cache().
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Alberto Garcia <berto@igalia.com>
> Reviewed-by: Greg Kurz <groug@kaod.org>
> ---
> block/qed.c | 24 +++++++++++++++---------
> 1 file changed, 15 insertions(+), 9 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-02-12 22:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 12:49 [PATCH v7 00/14] block: deal with errp: part I Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 01/14] block: return status from bdrv_append and friends Vladimir Sementsov-Ogievskiy
2021-02-05 11:16 ` Alberto Garcia
2021-02-05 11:26 ` Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 02/14] block: use return status of bdrv_append() Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 03/14] block: check return value of bdrv_open_child and drop error propagation Vladimir Sementsov-Ogievskiy
2021-02-12 23:13 ` Eric Blake
2021-02-15 9:22 ` Kevin Wolf
2021-02-15 20:04 ` Eric Blake
2021-02-16 5:03 ` Vladimir Sementsov-Ogievskiy
2021-02-16 9:02 ` Kevin Wolf
2021-02-02 12:49 ` [PATCH v7 04/14] blockdev: fix drive_backup_prepare() missed error Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 05/14] block: drop extra error propagation for bdrv_set_backing_hd Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 06/14] block/mirror: drop extra error propagation in commit_active_start() Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 07/14] blockjob: return status from block_job_set_speed() Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation Vladimir Sementsov-Ogievskiy
2021-02-05 11:43 ` Alberto Garcia
2021-02-05 11:52 ` Vladimir Sementsov-Ogievskiy
2021-02-05 12:01 ` Alberto Garcia
2021-02-12 19:44 ` Eric Blake
2021-02-02 12:49 ` [PATCH v7 09/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 10/14] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 11/14] block/qcow2: read_cache_sizes: return status value Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 12/14] block/qcow2: simplify qcow2_co_invalidate_cache() Vladimir Sementsov-Ogievskiy
2021-02-02 12:49 ` [PATCH v7 13/14] block/qed: bdrv_qed_do_open: deal with errp Vladimir Sementsov-Ogievskiy
2021-02-12 22:18 ` Eric Blake [this message]
2021-02-02 12:49 ` [PATCH v7 14/14] block/qcow2: refactor qcow2_update_options_prepare error paths Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd3a8b99-99d6-96e8-3a0b-0ec6930cdc55@redhat.com \
--to=eblake@redhat.com \
--cc=ari@tuxera.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=groug@kaod.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).