From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Inès Varhol" <ines.varhol@telecom-paris.fr>, qemu-devel@nongnu.org
Cc: Alistair Francis <alistair@alistair23.me>,
Arnaud Minier <arnaud.minier@telecom-paris.fr>,
Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-arm@nongnu.org
Subject: Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase
Date: Thu, 4 Jan 2024 14:33:10 +0100 [thread overview]
Message-ID: <cd41459a-b96d-4b51-bc2a-37724ccc4db1@linaro.org> (raw)
In-Reply-To: <20231228161944.303768-3-ines.varhol@telecom-paris.fr>
On 28/12/23 17:19, Inès Varhol wrote:
> Signed-off-by: Arnaud Minier <arnaud.minier@telecom-paris.fr>
> Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
> ---
> tests/qtest/meson.build | 5 +
> tests/qtest/stm32l4x5_exti-test.c | 596 ++++++++++++++++++++++++++++++
> 2 files changed, 601 insertions(+)
> create mode 100644 tests/qtest/stm32l4x5_exti-test.c
Once the SoC parentship fixed in based series, this patch
requires:
-- >8 --
diff --git a/tests/qtest/stm32l4x5_exti-test.c
b/tests/qtest/stm32l4x5_exti-test.c
index 60c8297246..543199cd4d 100644
--- a/tests/qtest/stm32l4x5_exti-test.c
+++ b/tests/qtest/stm32l4x5_exti-test.c
@@ -287,4 +287,3 @@ static void test_edge_selector(void)
/* Configure EXTI line 0 irq on rising edge */
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 0, 1);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 1);
exti_writel(EXTI_IMR1, 0x00000001);
@@ -294,4 +293,3 @@ static void test_edge_selector(void)
/* Test that an irq is raised on rising edge only */
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 0, 0);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 0);
@@ -301,4 +299,3 @@ static void test_edge_selector(void)
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 0, 1);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 1);
@@ -316,4 +313,3 @@ static void test_edge_selector(void)
/* Configure EXTI line 0 irq on falling edge */
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 0, 0);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 0);
exti_writel(EXTI_IMR1, 0x00000001);
@@ -323,4 +319,3 @@ static void test_edge_selector(void)
/* Test that an irq is raised on falling edge only */
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 0, 1);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 1);
@@ -330,4 +325,3 @@ static void test_edge_selector(void)
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 0, 0);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 0);
@@ -350,4 +344,3 @@ static void test_edge_selector(void)
/* Test that an irq is raised on rising and falling edge */
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 0, 1);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 1);
@@ -357,4 +350,3 @@ static void test_edge_selector(void)
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 0, 0);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 0);
@@ -377,4 +369,3 @@ static void test_edge_selector(void)
/* Test that no irq is raised */
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 0, 1);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 1);
@@ -384,4 +375,3 @@ static void test_edge_selector(void)
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 0, 0);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 0);
@@ -500,4 +490,3 @@ static void test_masked_interrupt(void)
/* Simulate rising edge from GPIO line 1 */
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 1, 1);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 1, 1);
@@ -550,4 +539,3 @@ static void test_interrupt(void)
/* Simulate rising edge from GPIO line 1 */
- qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
- NULL, 1, 1);
+ qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 1, 1);
---
Note you could use a helper to ease readability:
static void exti_set_irq(int num, int lvl)
{
qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, num, lvl);
}
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-01-04 13:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 16:19 [PATCH v5 0/3] Add device STM32L4x5 EXTI Inès Varhol
2023-12-28 16:19 ` [PATCH v5 1/3] hw/misc: Implement " Inès Varhol
2024-01-04 13:14 ` Philippe Mathieu-Daudé
2024-01-04 13:23 ` Samuel Tardieu
2024-01-04 13:40 ` Philippe Mathieu-Daudé
2024-01-04 13:59 ` Samuel Tardieu
2024-01-04 14:06 ` inesvarhol
2023-12-28 16:19 ` [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase Inès Varhol
2024-01-04 3:39 ` Alistair Francis
2024-01-04 13:05 ` Philippe Mathieu-Daudé
2024-01-04 13:37 ` inesvarhol
2024-01-05 10:13 ` Philippe Mathieu-Daudé
2024-01-05 10:19 ` Philippe Mathieu-Daudé
2024-01-08 16:15 ` Markus Armbruster
2024-01-07 14:04 ` Mark Cave-Ayland
2024-01-08 16:21 ` Markus Armbruster
2024-01-05 10:24 ` Daniel P. Berrangé
2024-01-05 22:16 ` Philippe Mathieu-Daudé
2024-01-04 13:33 ` Philippe Mathieu-Daudé [this message]
2024-01-04 13:45 ` inesvarhol
2023-12-28 16:19 ` [PATCH v5 3/3] hw/arm: Connect STM32L4x5 EXTI to STM32L4x5 SoC Inès Varhol
2024-01-04 3:42 ` Alistair Francis
2024-01-04 13:17 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd41459a-b96d-4b51-bc2a-37724ccc4db1@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=arnaud.minier@telecom-paris.fr \
--cc=ines.varhol@telecom-paris.fr \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).