From: Thomas Huth <thuth@redhat.com>
To: "Hongren (Zenithal) Zheng" <i@zenithal.me>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, contact@canokeys.org
Subject: Re: [PATCH v2 4/6] docs: Add CanoKey documentation
Date: Thu, 13 Jan 2022 10:51:58 +0100 [thread overview]
Message-ID: <cd41d157-842d-4da9-93e1-7bb6f98c764f@redhat.com> (raw)
In-Reply-To: <YdheTvpyyiAwDafr@Sun>
On 07/01/2022 16.37, Hongren (Zenithal) Zheng wrote:
> Signed-off-by: Hongren (Zenithal) Zheng <i@zenithal.me>
> ---
> docs/canokey.txt | 140 +++++++++++++++++++++++++++++++++++++++++++++++
I think this should likely rather go into the docs/system/devices directory
instead? And it would be nice if you could also turn it into a reStructured
text (*.rst) document right from the start.
Thanks,
Thomas
next prev parent reply other threads:[~2022-01-13 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 15:32 [PATCH v2 0/6] Introduce CanoKey QEMU Hongren (Zenithal) Zheng
2022-01-07 15:34 ` [PATCH v2 1/6] hw/usb: Add CanoKey Implementation Hongren (Zenithal) Zheng
2022-01-07 15:35 ` [PATCH v2 2/6] hw/usb/canokey: Add trace events Hongren (Zenithal) Zheng
2022-01-13 9:33 ` Gerd Hoffmann
2022-01-07 15:35 ` [PATCH v2 3/6] meson: Add CanoKey Hongren (Zenithal) Zheng
2022-01-07 15:37 ` [PATCH v2 4/6] docs: Add CanoKey documentation Hongren (Zenithal) Zheng
2022-01-13 9:51 ` Thomas Huth [this message]
2022-01-07 15:38 ` [PATCH v2 5/6] docs/system/devices/usb: Add CanoKey to USB devices examples Hongren (Zenithal) Zheng
2022-01-07 15:38 ` [PATCH v2 6/6] MAINTAINERS: add myself as CanoKey maintainer Hongren (Zenithal) Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd41d157-842d-4da9-93e1-7bb6f98c764f@redhat.com \
--to=thuth@redhat.com \
--cc=contact@canokeys.org \
--cc=i@zenithal.me \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).