Re: [Qemu-devel] [PATCH v1 for-2.11 06/10] target/s390x: introduce internal.h

[Thomas Huth <thuth@redhat.com>]

On 17.08.2017 11:22, David Hildenbrand wrote:
> cpu.h should only contain what really has to be accessed outside of
> target/s390x/. Add internal.h which can only be used inside target/s390x/.
> 
> Move everything that isn't fast enough to run away and restructure it
> right away. We'll move all kvm_* stuff later.
> 
> Minor style fixes to avoid checkpatch warning to:
> - struct Lowcore: "{" goes into same line as typedef
> - struct LowCore: add spaces around "-" in array length calculations
> - time2tod() and tod2time(): move "{" to separate line
> - get_per_atmid(): add space between ")" and "?". Move cases by one char.
> - get_per_atmid(): drop extra paremthesis around (1 << 6)
> 
> Change license of new file to GPL2+ and keep copyright notice.
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  target/s390x/arch_dump.c   |   1 +
>  target/s390x/cc_helper.c   |   1 +
>  target/s390x/cpu.c         |   1 +
>  target/s390x/cpu.h         | 343 ---------------------------------------
>  target/s390x/cpu_models.c  |   1 +
>  target/s390x/diag.c        |   1 +
>  target/s390x/excp_helper.c |   1 +
>  target/s390x/fpu_helper.c  |   1 +
>  target/s390x/gdbstub.c     |   1 +
>  target/s390x/helper.c      |   1 +
>  target/s390x/int_helper.c  |   1 +
>  target/s390x/internal.h    | 391 +++++++++++++++++++++++++++++++++++++++++++++
>  target/s390x/interrupt.c   |   1 +
>  target/s390x/ioinst.c      |   1 +
>  target/s390x/kvm.c         |   1 +
>  target/s390x/machine.c     |   1 +
>  target/s390x/mem_helper.c  |   1 +
>  target/s390x/misc_helper.c |   1 +
>  target/s390x/mmu_helper.c  |   1 +
>  target/s390x/translate.c   |   1 +
>  20 files changed, 409 insertions(+), 343 deletions(-)
>  create mode 100644 target/s390x/internal.h

Reviewed-by: Thomas Huth <thuth@redhat.com>