From: David Hildenbrand <david@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: cohuck@redhat.com, jack@suse.cz, kvm@vger.kernel.org,
mst@redhat.com, jasowang@redhat.com, david@fromorbit.com,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
adilger kernel <adilger.kernel@dilger.ca>,
zwisler@kernel.org, aarcange@redhat.com,
dave jiang <dave.jiang@intel.com>,
jstaron@google.com, linux-nvdimm@lists.01.org,
vishal l verma <vishal.l.verma@intel.com>,
willy@infradead.org, hch@infradead.org,
linux-acpi@vger.kernel.org, jmoyer@redhat.com,
linux-ext4@vger.kernel.org, lenb@kernel.org, kilobyte@angband.pl,
riel@surriel.com, yuval shaia <yuval.shaia@oracle.com>,
stefanha@redhat.com, pbonzini@redhat.com,
dan j williams <dan.j.williams@intel.com>,
lcapitulino@redhat.com, kwolf@redhat.com, nilal@redhat.com,
tytso@mit.edu, xiaoguangrong eric <xiaoguangrong.eric@gmail.com>,
darrick wong <darrick.wong@oracle.com>,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver
Date: Tue, 14 May 2019 11:57:05 +0200 [thread overview]
Message-ID: <cd5572ac-14d0-f872-6321-c522daa70f49@redhat.com> (raw)
In-Reply-To: <712871093.28555872.1557827242385.JavaMail.zimbra@redhat.com>
>>
>> I think you should do the same here, vdev->priv is allocated in
>> virtio_pmem_probe.
>>
>> But maybe I am missing something important here :)
>
> Because virtio_balloon use "kzalloc" for allocation and needs to be freed.
> But virtio pmem uses "devm_kzalloc" which takes care of automatically deleting
> the device memory when associated device is detached.
Hehe, thanks, that was the part that I was missing!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-05-14 10:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 15:51 [Qemu-devel] [PATCH v8 0/6] virtio pmem driver Pankaj Gupta
2019-05-10 15:51 ` [Qemu-devel] [PATCH v8 1/6] libnvdimm: nd_region flush callback support Pankaj Gupta
2019-05-10 15:51 ` [Qemu-devel] [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver Pankaj Gupta
2019-05-12 16:51 ` Michael S. Tsirkin
2019-05-13 4:43 ` Pankaj Gupta
2019-05-14 8:19 ` David Hildenbrand
2019-05-14 9:27 ` Pankaj Gupta
2019-05-14 9:34 ` David Hildenbrand
2019-05-14 9:47 ` Pankaj Gupta
2019-05-14 9:57 ` David Hildenbrand [this message]
2019-05-14 10:02 ` Pankaj Gupta
2019-05-10 15:51 ` [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag Pankaj Gupta
2019-05-10 20:14 ` Dan Williams
2019-05-11 0:45 ` Pankaj Gupta
2019-05-11 0:59 ` Dan Williams
2019-05-11 1:23 ` Pankaj Gupta
2019-05-13 17:32 ` Pankaj Gupta
2019-05-13 17:52 ` Dan Williams
2019-05-14 5:27 ` Pankaj Gupta
2019-05-10 15:52 ` [Qemu-devel] [PATCH v8 4/6] dax: check synchronous mapping is supported Pankaj Gupta
2019-05-10 15:52 ` [Qemu-devel] [PATCH v8 5/6] ext4: disable map_sync for async flush Pankaj Gupta
2019-05-10 15:52 ` [Qemu-devel] [PATCH v8 6/6] xfs: " Pankaj Gupta
2019-05-10 16:30 ` [Qemu-devel] [PATCH v8 0/6] virtio pmem driver Michael S. Tsirkin
2019-05-10 20:15 ` Dan Williams
2019-05-10 23:33 ` Pankaj Gupta
2019-05-12 16:52 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd5572ac-14d0-f872-6321-c522daa70f49@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=imammedo@redhat.com \
--cc=jack@suse.cz \
--cc=jasowang@redhat.com \
--cc=jmoyer@redhat.com \
--cc=jstaron@google.com \
--cc=kilobyte@angband.pl \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@surriel.com \
--cc=rjw@rjwysocki.net \
--cc=stefanha@redhat.com \
--cc=tytso@mit.edu \
--cc=virtualization@lists.linux-foundation.org \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yuval.shaia@oracle.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).