From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 760E8C433B4 for ; Fri, 16 Apr 2021 18:14:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3AC5611AB for ; Fri, 16 Apr 2021 18:14:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3AC5611AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXSzK-0001Qb-40 for qemu-devel@archiver.kernel.org; Fri, 16 Apr 2021 14:14:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXSFO-0006xl-Is for qemu-devel@nongnu.org; Fri, 16 Apr 2021 13:27:14 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:45924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXSFM-000279-On for qemu-devel@nongnu.org; Fri, 16 Apr 2021 13:27:14 -0400 Received: by mail-pf1-x42f.google.com with SMTP id i190so18776132pfc.12 for ; Fri, 16 Apr 2021 10:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TINj31AaZ3ru4S2L8k1HcfiDczgVWPxvOReG4kcymDA=; b=a4Rssjvy5gsHQawnF4jVOHQHPUXiwEdkwZra0rAJIiPtUUBI1TyHI1ufzFiwcxmuNk bMBnQFxBYyzf3+4Joam+HTXHMy99UFnOD8JjT7ur3TeRVs38FnAKjzm+ps5speKnUoc2 xGzA6pBFuYrtaIUMSOrfh+PmSNs4tmd0Yo801zB8oeqD6KS+C65Fc1mQhs2BUFtuTxdh 2JhtdEIKqjq2ESWL3GSD2R0Z4IzIyc6XRCQms+9B18c61BfMosbA3L2XFQ/2FSmbCMvY 4x+LL6sxY048/Sa5eJE7M53f/bamC2eaX02fjEyucrtZAdnH7qKqkLyuzq0Jd9sKFHy6 xAHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TINj31AaZ3ru4S2L8k1HcfiDczgVWPxvOReG4kcymDA=; b=uh+YQXs4sn7U0mNLQuSh5XOvh5PQmswfd/ktcL17sPK2OuG2kA6v3y4A8Z1zA37CrC X1SRuRmmrEfo3YJ5ppClSKPGJrRijMyA9s0+28Plkyvuv43aTU6bH/tbGXhkRQnJOgjL wlGgFQnt30kXahyxJC+IQDeBohBaG/ZU3BsmFh6DoC+3tnYRrYqVvNFNgWvz//PNP8UM gOLErHcLy2qKyCD/gW18U8HVEnPKwNfvy2IEk2I2rxYMOs4/m7Yodk4vgkaCqqXafV0Z RS8e4XLyy3kUpRRkQbLBUQzR1yd3d+xT9tmr0wlhhSdaQyVSMtJhFgeRpPtJ057VQSXN JKIQ== X-Gm-Message-State: AOAM531mEJXKVxeX3x+kJzMVLGlPzyah1mKE1CUQxP/DiOJPoQNorlVS 0gQp6/tsgTEK2G5kd4ydC+wwQSNsME6A0w== X-Google-Smtp-Source: ABdhPJwTLUkReW2ec10hRD9MBPFuVxHCBJqbO9uYKxZHMfTnrow9D0u6GaYoFkaRAH4iY+AxCBhu9w== X-Received: by 2002:a62:e402:0:b029:259:baff:e8e5 with SMTP id r2-20020a62e4020000b0290259baffe8e5mr4551653pfh.81.1618594030320; Fri, 16 Apr 2021 10:27:10 -0700 (PDT) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id j20sm5942640pjn.27.2021.04.16.10.27.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 10:27:09 -0700 (PDT) Subject: Re: [PATCH v5] i386/cpu_dump: support AVX512 ZMM regs dump To: Robert Hoo , pbonzini@redhat.com, ehabkost@redhat.com References: <1618538904-93433-1-git-send-email-robert.hu@linux.intel.com> From: Richard Henderson Message-ID: Date: Fri, 16 Apr 2021 10:27:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1618538904-93433-1-git-send-email-robert.hu@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/15/21 7:08 PM, Robert Hoo wrote: > Since commit fa4518741e (target-i386: Rename struct XMMReg to ZMMReg), > CPUX86State.xmm_regs[] has already been extended to 512bit to support > AVX512. > Also, other qemu level supports for AVX512 registers are there for > years. > But in x86_cpu_dump_state(), still only dump XMM registers no matter > YMM/ZMM is enabled. > This patch is to complement this, let it dump XMM/YMM/ZMM accordingly. > > Signed-off-by: Robert Hoo > --- > Changelog: > v5: fix a minor issue. rebase to latest master. > v4: stringent AVX512 case and AVX case judgement criteria > v3: fix some coding style issue. > v2: dump XMM/YMM/ZMM according to XSAVE state-components enablement. > target/i386/cpu-dump.c | 62 ++++++++++++++++++++++++++++++++++++++------------ > 1 file changed, 47 insertions(+), 15 deletions(-) Reviewed-by: Richard Henderson r~