Re: [PATCH] tests/acceptance: Add a test for the canon-a1100 machine

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 1/27/20 3:41 PM, Thomas Huth wrote:
> The canon-a1100 machine can be used with the Barebox firmware. The
> QEMU Advent Calendar 2018 features a pre-compiled image which we
> can use for testing.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/acceptance/machine_arm_canon-a1100.py | 33 +++++++++++++++++++++
>   1 file changed, 33 insertions(+)
>   create mode 100644 tests/acceptance/machine_arm_canon-a1100.py
> 
> diff --git a/tests/acceptance/machine_arm_canon-a1100.py b/tests/acceptance/machine_arm_canon-a1100.py
> new file mode 100644
> index 0000000000..3888168451
> --- /dev/null
> +++ b/tests/acceptance/machine_arm_canon-a1100.py
> @@ -0,0 +1,33 @@
> +# Functional test that boots the canon-a1100 machine with firmware
> +#
> +# Copyright (c) 2020 Red Hat, Inc.
> +#
> +# Author:
> +#  Thomas Huth <thuth@redhat.com>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2 or
> +# later.  See the COPYING file in the top-level directory.
> +
> +from avocado_qemu import Test
> +from avocado_qemu import wait_for_console_pattern
> +from avocado.utils import archive
> +
> +class CanonA1100Machine(Test):
> +
> +    timeout = 90
> +
> +    def test_arm_canona1100(self):
> +        """
> +        :avocado: tags=arch:arm
> +        :avocado: tags=machine:canon-a1100

To the maintainer taking this, please add:

            :avocado: tags=pflash_cfi02

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

console: Switch to console [cs0]
console: barebox 2017.02.0 #2 Mon Nov 12 09:28:33 CET 2018
console: Board: Canon PowerShot A1100 IS
console: digic-gpio c0220000.gpio: probed gpiochip-1 with base 0
console: cfi_flash f8000000.flash: found cfi flash at 0xf8000000, size 4 MiB
console: malloc space: 0x00100000 -> 0x002fffff (size 2 MiB)
console: environment load /dev/env0: No such file or directory
console: Maybe you have to create the partition.
console: running /env/bin/init...
PASS (1.86 s)

Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> +        """
> +        tar_url = ('https://www.qemu-advent-calendar.org'
> +                   '/2018/download/day18.tar.xz')
> +        tar_hash = '068b5fc4242b29381acee94713509f8a876e9db6'
> +        file_path = self.fetch_asset(tar_url, asset_hash=tar_hash)
> +        archive.extract(file_path, self.workdir)
> +        self.vm.set_console()
> +        self.vm.add_args('-bios',
> +                         self.workdir + '/day18/barebox.canon-a1100.bin')
> +        self.vm.launch()
> +        wait_for_console_pattern(self, 'running /env/bin/init')
>