qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>
Cc: cota@braap.org, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH for-8.0 11/11] linux-user/arm: Take more care allocating commpage
Date: Mon, 27 Mar 2023 14:47:42 +0200	[thread overview]
Message-ID: <cd6f0fbe-d30d-b548-31ce-533a154402aa@linaro.org> (raw)
In-Reply-To: <87zg7ysi4y.fsf@linaro.org>

On 27/3/23 10:38, Alex Bennée wrote:
> 
> Richard Henderson <richard.henderson@linaro.org> writes:
> 
>> User setting of -R reserved_va can lead to an assertion
>> failure in page_set_flags.  Sanity check the value of
>> reserved_va and print an error message instead.  Do not
>> allocate a commpage at all for m-profile cpus.
> 
> I see this:
> 
>    TEST    convd on i386
> qemu-i386: Unable to reserve 0x100000000 bytes of virtual address space
> at 0x8000 (File exists) for use as guest address space (check your
> virtual memory ulimit setting, min_mmap_addr or reserve less using -R
> option)

Maybe revealing some pre-existing issue?
https://gitlab.com/qemu-project/qemu/-/issues/447

> 
> on the ubuntu aarch64 static build:
> 
>    https://gitlab.com/stsquad/qemu/-/jobs/4003523064
> 
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   linux-user/elfload.c | 37 +++++++++++++++++++++++++++----------
>>   1 file changed, 27 insertions(+), 10 deletions(-)



  reply	other threads:[~2023-03-27 12:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 15:07 [PATCH for-8.0 00/11] tcg patch queue Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 01/11] util: import GTree as QTree Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 02/11] tcg: use QTree instead of GTree Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 03/11] linux-user: Diagnose misaligned -R size Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 04/11] include/exec: Change reserved_va semantics to last byte Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 05/11] accel/tcg: Pass last not end to page_set_flags Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 06/11] accel/tcg: Pass last not end to page_reset_target_data Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 07/11] accel/tcg: Pass last not end to PAGE_FOR_EACH_TB Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 08/11] accel/tcg: Pass last not end to page_collection_lock Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 09/11] accel/tcg: Pass last not end to tb_invalidate_phys_page_range__locked Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 10/11] accel/tcg: Pass last not end to tb_invalidate_phys_range Richard Henderson
2023-03-22 15:07 ` [PATCH for-8.0 11/11] linux-user/arm: Take more care allocating commpage Richard Henderson
2023-03-27  8:38   ` Alex Bennée
2023-03-27 12:47     ` Philippe Mathieu-Daudé [this message]
2023-03-27 17:36     ` Richard Henderson
2023-03-27 19:27       ` Richard Henderson
2023-03-27 19:42       ` Alex Bennée
2023-03-26  4:51 ` [PATCH for-8.0 00/11] tcg patch queue Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd6f0fbe-d30d-b548-31ce-533a154402aa@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=cota@braap.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).