qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Nir Soffer <nirsof@gmail.com>, Ala Hino <ahino@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	qemu-discuss@nongnu.org, Nir Soffer <nsoffer@redhat.com>,
	John Snow Huston <jsnow@redhat.com>
Subject: Re: [Qemu-devel] Supporting unsafe create when backing file is not accessible
Date: Mon, 17 Jul 2017 07:25:09 -0500	[thread overview]
Message-ID: <cd8a80fe-4ac9-5f34-ce1f-d512eee7f703@redhat.com> (raw)
In-Reply-To: <20170717121910.GG5301@noname.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

On 07/17/2017 07:19 AM, Kevin Wolf wrote:

> While I think adding -u today is reasonably realistic, I'm doubtful that
> we can get an introspection mechanism in place today. Perhaps we can
> declare it a bug fix, but I'd rather not rush something like that.
> 
> How does libvirt detect qemu-img features today? Just try and then check
> the error message?

Yeah, when it comes to non-advertised feature detection, the best you
can do is try using the feature, and fall back to the older approach if
the feature was not present (this approach only works for features that
gracefully fail without side effects when attempted on older versions,
but fortunately that's the case for most true feature additions).

And note that creating an image without a backing file, then using
'qemu-img rebase -u' to give it a backing image without probing the
backing image, IS currently documented and supported (so we DO have a
safe fallback, regardless of when 'qemu-img create -u ... size' actually
lands).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2017-07-17 12:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12  8:56 [Qemu-devel] Supporting unsafe create when backing file is not accessible Ala Hino
2017-07-12 14:39 ` Eric Blake
2017-07-14 19:13   ` Nir Soffer
2017-07-17  8:42     ` Kevin Wolf
2017-07-17 11:36     ` Eric Blake
2017-07-17 12:19       ` Kevin Wolf
2017-07-17 12:25         ` Eric Blake [this message]
2017-07-17 12:39           ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd8a80fe-4ac9-5f34-ce1f-d512eee7f703@redhat.com \
    --to=eblake@redhat.com \
    --cc=ahino@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=nirsof@gmail.com \
    --cc=nsoffer@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-discuss@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).