From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15783C77B73 for ; Thu, 20 Apr 2023 08:18:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppPU8-0007c6-0D; Thu, 20 Apr 2023 04:17:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppPU6-0007bk-Ts for qemu-devel@nongnu.org; Thu, 20 Apr 2023 04:17:42 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppPU0-00045O-Tb for qemu-devel@nongnu.org; Thu, 20 Apr 2023 04:17:42 -0400 Received: by mail-wm1-x32a.google.com with SMTP id he13so823154wmb.2 for ; Thu, 20 Apr 2023 01:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681978654; x=1684570654; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f13MQ93ddq/Nd75N1ll36Z5zAz1KfuOg0cGpRV2ear0=; b=Dctjjv3Her1C+F0+KW0Qt046ZCEeDgZkO8003lMWpMr0cRK2zh6yCL6RYOmwdiFB6B zmVyNkKHCVk8PWYN3iSJuDcg/Hz/2pl7O56QaaORZ062381fPJidzo9qZzw2LJo4+PWS yU+r2fu7RH06XYw+XmjTlXFB3H5PlhyY4vJRDzWOIcLPu6vIoNpwcPWZDMmpOjjGIrrP Zx2XXZBP/gitGY/tqxUfd5jSGImn2wm+RiPX2kUPGke3B0mUvaeCM1+R6PUZNgtS1js4 kDoD9FFhmx9jmoJroTu5BK21cqrW4TfUQjOAIvDyUfNtZJk3wnMEwpE+HJreU0YNXdnO e14w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681978654; x=1684570654; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f13MQ93ddq/Nd75N1ll36Z5zAz1KfuOg0cGpRV2ear0=; b=evbbOOaYdf+MlkQm4Dvp6ugHElcw/qRcjekl3IkKikkiHKSurUg+FWfTUnLyZpQmSi Yl5CNj3A1+vnH3EbTVWpz7Gc8GmLrMM0Nx+3+Z4WbOWEEDhFBpQG1TtUgIe+5xlhbucw 8122bp/YF5DyogCDWsjRTWSuGuK3e4uy6jLaOwe2lx5HUekwuUslIr5fQ57YpbU0LJ9P ddOZLSToED/An4PoDVH4r0lbVXA/XoglH6rQ6pCuL+6UbQpOVd8bAZmtSYHUPqDC+BiY Svra6cOpll8wZs5/wZXlNHWczUm58e+wl515ETAyowI8GJB8KMbOJdZx2AEu7Om1v+4p jpiQ== X-Gm-Message-State: AAQBX9eXL2u2sKfZ5VJLDTzvAhjzhSVi/kHVqFmlPgWBEE5c/ZZnaMIl pJIyyNuX/pptZcTI0IotUyvAHg== X-Google-Smtp-Source: AKy350a+S7Bo5cgeIITonHrFz17ZzQ14J39mXHJXktyn9+4RrBlds2+14MAKJinCJiahV/R/tP2QIA== X-Received: by 2002:a05:600c:2183:b0:3f1:7848:6740 with SMTP id e3-20020a05600c218300b003f178486740mr647559wme.8.1681978654594; Thu, 20 Apr 2023 01:17:34 -0700 (PDT) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id k6-20020a5d5246000000b002fe87e0706bsm1247834wrc.97.2023.04.20.01.17.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 01:17:33 -0700 (PDT) Message-ID: Date: Thu, 20 Apr 2023 10:17:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 01/16] hw/qdev: introduce qdev_is_realized() helper Content-Language: en-US To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Stefano Stabellini , Marcel Apfelbaum , Fam Zheng , Julia Suvorova , Hanna Reitz , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Paolo Bonzini , Coiby Xu , Paul Durrant , Ronnie Sahlberg , Eduardo Habkost , Juan Quintela , "Michael S. Tsirkin" , Stefano Garzarella , Anthony Perard , Kevin Wolf , "Richard W.M. Jones" , Richard Henderson , xen-devel@lists.xenproject.org, qemu-block@nongnu.org, "Dr. David Alan Gilbert" , Peter Lieven , eesposit@redhat.com, Aarushi Mehta , Stefan Weil , Xie Yongji , David Woodhouse References: <20230419172817.272758-1-stefanha@redhat.com> <20230419172817.272758-2-stefanha@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230419172817.272758-2-stefanha@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.597, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 19/4/23 19:28, Stefan Hajnoczi wrote: > Add a helper function to check whether the device is realized without > requiring the Big QEMU Lock. The next patch adds a second caller. The > goal is to avoid spreading DeviceState field accesses throughout the > code. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Stefan Hajnoczi > --- > include/hw/qdev-core.h | 17 ++++++++++++++--- > hw/scsi/scsi-bus.c | 3 +-- > 2 files changed, 15 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé Thank you!