* Re: [qemu PATCH] hw/cxl/cxl_device: Replace magic number in CXLError definition
2023-03-14 16:53 ` [qemu PATCH] hw/cxl/cxl_device: Replace magic number in CXLError definition Fan Ni
@ 2023-03-14 17:29 ` Davidlohr Bueso
2023-03-14 18:34 ` Dave Jiang
1 sibling, 0 replies; 3+ messages in thread
From: Davidlohr Bueso @ 2023-03-14 17:29 UTC (permalink / raw)
To: Fan Ni
Cc: qemu-devel@nongnu.org, jonathan.cameron@huawei.com,
linux-cxl@vger.kernel.org, alison.schofield@intel.com,
Adam Manzanares, bwidawsk@kernel.org, gregory.price@memverge.com,
hchkuo@avery-design.com.tw, cbrowy@avery-design.com,
ira.weiny@intel.com
On Tue, 14 Mar 2023, Fan Ni wrote:
>Replace the magic number 32 with CXL_RAS_ERR_HEADER_NUM for better code
>readability and maintainability.
>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
>Signed-off-by: Fan Ni <fan.ni@samsung.com>
>---
> include/hw/cxl/cxl_device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h
>index d589f78202..34fde62eac 100644
>--- a/include/hw/cxl/cxl_device.h
>+++ b/include/hw/cxl/cxl_device.h
>@@ -235,7 +235,7 @@ REG64(CXL_MEM_DEV_STS, 0)
> typedef struct CXLError {
> QTAILQ_ENTRY(CXLError) node;
> int type; /* Error code as per FE definition */
>- uint32_t header[32];
>+ uint32_t header[CXL_RAS_ERR_HEADER_NUM];
> } CXLError;
>
> typedef QTAILQ_HEAD(, CXLError) CXLErrorList;
>--
>2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [qemu PATCH] hw/cxl/cxl_device: Replace magic number in CXLError definition
2023-03-14 16:53 ` [qemu PATCH] hw/cxl/cxl_device: Replace magic number in CXLError definition Fan Ni
2023-03-14 17:29 ` Davidlohr Bueso
@ 2023-03-14 18:34 ` Dave Jiang
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2023-03-14 18:34 UTC (permalink / raw)
To: Fan Ni, qemu-devel@nongnu.org
Cc: jonathan.cameron@huawei.com, linux-cxl@vger.kernel.org,
alison.schofield@intel.com, dave@stgolabs.net, Adam Manzanares,
bwidawsk@kernel.org, gregory.price@memverge.com,
hchkuo@avery-design.com.tw, cbrowy@avery-design.com,
ira.weiny@intel.com
On 3/14/23 9:53 AM, Fan Ni wrote:
> Replace the magic number 32 with CXL_RAS_ERR_HEADER_NUM for better code
> readability and maintainability.
>
> Signed-off-by: Fan Ni <fan.ni@samsung.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> include/hw/cxl/cxl_device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h
> index d589f78202..34fde62eac 100644
> --- a/include/hw/cxl/cxl_device.h
> +++ b/include/hw/cxl/cxl_device.h
> @@ -235,7 +235,7 @@ REG64(CXL_MEM_DEV_STS, 0)
> typedef struct CXLError {
> QTAILQ_ENTRY(CXLError) node;
> int type; /* Error code as per FE definition */
> - uint32_t header[32];
> + uint32_t header[CXL_RAS_ERR_HEADER_NUM];
> } CXLError;
>
> typedef QTAILQ_HEAD(, CXLError) CXLErrorList;
^ permalink raw reply [flat|nested] 3+ messages in thread