From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bw5Jv-0005oM-6t for qemu-devel@nongnu.org; Mon, 17 Oct 2016 06:39:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bw5Jp-0008Qw-6E for qemu-devel@nongnu.org; Mon, 17 Oct 2016 06:39:03 -0400 References: <1476700224-13186-1-git-send-email-lvivier@redhat.com> <1476700224-13186-3-git-send-email-lvivier@redhat.com> From: Thomas Huth Message-ID: Date: Mon, 17 Oct 2016 12:38:52 +0200 MIME-Version: 1.0 In-Reply-To: <1476700224-13186-3-git-send-email-lvivier@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 2/6] tests: don't check if qtest_spapr_boot() returns NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: dgibson@redhat.com, qemu-ppc@nongnu.org, Greg Kurz On 17.10.2016 12:30, Laurent Vivier wrote: > qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot() > and qtest_vboot() calls g_malloc(), > and g_malloc() never fails: > if memory allocation fails, the application is terminated. > > Signed-off-by: Laurent Vivier > --- > tests/libqos/libqos.c | 2 ++ > tests/rtas-test.c | 1 - > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c > index 7abb482..6226546 100644 > --- a/tests/libqos/libqos.c > +++ b/tests/libqos/libqos.c > @@ -10,6 +10,8 @@ > /** > * Launch QEMU with the given command line, > * and then set up interrupts and our guest malloc interface. > + * Never returns NULL: > + * Terminates the application in case an error is encountered. > */ > QOSState *qtest_vboot(QOSOps *ops, const char *cmdline_fmt, va_list ap) > { > diff --git a/tests/rtas-test.c b/tests/rtas-test.c > index ba0867a..276c87e 100644 > --- a/tests/rtas-test.c > +++ b/tests/rtas-test.c > @@ -14,7 +14,6 @@ static void test_rtas_get_time_of_day(void) > time_t t1, t2; > > qs = qtest_spapr_boot("-machine pseries"); > - g_assert(qs != NULL); > > t1 = time(NULL); > ret = qrtas_get_time_of_day(qs->alloc, &tm, &ns); > Reviewed-by: Thomas Huth