From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH] target/arm: Fix 32-bit SMOPA
Date: Tue, 5 Mar 2024 05:51:28 -1000 [thread overview]
Message-ID: <cdd286d6-2986-4c2c-8785-dc311b71e4fd@linaro.org> (raw)
In-Reply-To: <fa8f1d52-f88d-4107-abfa-fa10ebef511c@linaro.org>
On 3/4/24 23:19, Philippe Mathieu-Daudé wrote:
>> + uint32_t *za_row = &za[H4(tile_vslice_index(row))];
>> + uint32_t n = zn[H4(row)];
>> +
>> + for (col = 0; col < oprsz; ++col) {
>> + uint8_t pb = pm[H1(col >> 1)] >> ((col & 1) * 4);
>> + uint32_t *a = &za_row[col];
>
> Shouldn't this be:
>
> uint32_t *a = &za_row[H4(col)];
>
> to work on big endian hosts?
Oof. Yes, the H4 adjustment belongs here, not on za_row above.
r~
next prev parent reply other threads:[~2024-03-05 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 2:31 [PATCH] target/arm: Fix 32-bit SMOPA Richard Henderson
2024-03-05 9:19 ` Philippe Mathieu-Daudé
2024-03-05 15:51 ` Richard Henderson [this message]
2024-03-05 16:01 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdd286d6-2986-4c2c-8785-dc311b71e4fd@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).