From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, pbonzini@redhat.com
Subject: Re: [PATCH 7/8] Drop qemu_foo() socket API wrapper
Date: Tue, 22 Feb 2022 22:26:12 +0100 [thread overview]
Message-ID: <cdd60bac-f425-4d51-3ec0-5daa59decf8f@gmail.com> (raw)
In-Reply-To: <20220222194008.610377-8-marcandre.lureau@redhat.com>
On 22/2/22 20:40, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The socket API wrappers were initially introduced in commit
> 00aa0040 ("Wrap recv to avoid warnings"), but made redundatant with
> commit a2d96af4 ("osdep: add wrappers for socket functions") which fixes
> the win32 declarations and thus removed the earlier warnings.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/qemu-common.h | 19 -------------------
> crypto/cipher-afalg.c | 4 ++--
> crypto/hash-afalg.c | 4 ++--
> gdbstub.c | 2 +-
> io/channel-socket.c | 6 +++---
> net/socket.c | 24 ++++++++++++------------
> tests/qtest/e1000e-test.c | 4 ++--
> tests/qtest/libqtest.c | 4 ++--
> tests/qtest/npcm7xx_emc-test.c | 4 ++--
> tests/qtest/test-filter-mirror.c | 4 ++--
> tests/qtest/test-filter-redirector.c | 8 ++++----
> tests/qtest/virtio-net-test.c | 10 +++++-----
> tests/unit/socket-helpers.c | 2 +-
> util/osdep.c | 4 ++--
> util/qemu-sockets.c | 10 +++++-----
> 15 files changed, 45 insertions(+), 64 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-02-22 21:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 19:40 [PATCH 0/8] Misc build fixes and cleanups marcandre.lureau
2022-02-22 19:40 ` [PATCH 1/8] meson: fix generic location of vss headers marcandre.lureau
2022-02-22 19:40 ` [PATCH 2/8] qga/vss-win32: check old VSS SDK headers marcandre.lureau
2022-02-22 19:40 ` [PATCH 3/8] qga/vss: update informative message about MinGW marcandre.lureau
2022-02-22 19:40 ` [PATCH 4/8] meson: drop the .fa library suffix marcandre.lureau
2022-02-23 9:07 ` Paolo Bonzini
2022-02-23 9:14 ` Marc-André Lureau
2022-02-24 14:01 ` Paolo Bonzini
2022-02-22 19:40 ` [PATCH 5/8] meson: use chardev_ss dependencies marcandre.lureau
2022-02-22 19:40 ` [PATCH 6/8] char: move qemu_openpty_raw from util/ to char/ marcandre.lureau
2022-02-24 17:04 ` Marc-André Lureau
2022-02-26 7:38 ` Paolo Bonzini
2022-02-28 7:53 ` Marc-André Lureau
2022-02-28 9:13 ` Daniel P. Berrangé
2022-02-28 11:07 ` Peter Maydell
2022-02-28 11:14 ` Daniel P. Berrangé
2022-02-22 19:40 ` [PATCH 7/8] Drop qemu_foo() socket API wrapper marcandre.lureau
2022-02-22 21:26 ` Philippe Mathieu-Daudé [this message]
2022-02-24 15:53 ` Eric Blake
2022-02-22 19:40 ` [PATCH 8/8] Replace GCC_FMT_ATTR with G_GNUC_PRINTF marcandre.lureau
2022-02-24 14:03 ` [PATCH 0/8] Misc build fixes and cleanups Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdd60bac-f425-4d51-3ec0-5daa59decf8f@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).