Re: [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c

[David Hildenbrand <david@redhat.com>]

On 30.11.2017 15:05, Cornelia Huck wrote:
> It is not used anywhere.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>  target/s390x/helper.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index 246ba20f0d..35d9741918 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -31,24 +31,6 @@
>  #include "sysemu/sysemu.h"
>  #endif
>  
> -//#define DEBUG_S390
> -//#define DEBUG_S390_STDOUT
> -
> -#ifdef DEBUG_S390
> -#ifdef DEBUG_S390_STDOUT
> -#define DPRINTF(fmt, ...) \
> -    do { fprintf(stderr, fmt, ## __VA_ARGS__); \
> -         if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> -    do { qemu_log(fmt, ## __VA_ARGS__); } while (0)
> -#endif
> -#else
> -#define DPRINTF(fmt, ...) \
> -    do { } while (0)
> -#endif
> -
> -
>  #ifndef CONFIG_USER_ONLY
>  void s390x_tod_timer(void *opaque)
>  {
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David / dhildenb