From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Alberto Garcia <berto@igalia.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 11/25] blkverify: Make bdrv_dirname() return NULL
Date: Mon, 16 Jan 2017 17:09:22 -0600 [thread overview]
Message-ID: <cde665c6-4ad7-81b8-3d9e-a38145862bd3@redhat.com> (raw)
In-Reply-To: <20170116204921.31578-4-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
On 01/16/2017 02:49 PM, Max Reitz wrote:
> blkverify's BDSs have a file BDS, but we do not want this to be
> preferred over the raw node. There is no way to decide between the two
> (and not really a reason to, either), so just return NULL in blkverify's
> implementation of bdrv_dirname().
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/blkverify.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-01-16 23:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 18:14 [Qemu-devel] [PATCH v4 00/25] block: Fix some filename generation issues Max Reitz
2017-01-11 18:14 ` [Qemu-devel] [PATCH v4 01/25] block/mirror: Small absolute-paths simplification Max Reitz
2017-01-11 18:14 ` [Qemu-devel] [PATCH v4 02/25] block: Use children list in bdrv_refresh_filename Max Reitz
2017-01-11 18:14 ` [Qemu-devel] [PATCH v4 03/25] block: Add BDS.backing_overridden Max Reitz
2017-01-11 19:50 ` Eric Blake
2017-01-11 18:14 ` [Qemu-devel] [PATCH v4 04/25] block: Respect backing bs in bdrv_refresh_filename Max Reitz
2017-01-16 20:43 ` Eric Blake
2017-01-16 20:50 ` Max Reitz
2017-01-16 20:47 ` [Qemu-devel] [PATCH v4 05/25] block: Make path_combine() return the path Max Reitz
2017-01-16 20:48 ` [Qemu-devel] [PATCH v4 06/25] block: bdrv_get_full_backing_filename_from_...'s ret. val Max Reitz
2017-01-16 20:48 ` [Qemu-devel] [PATCH v4 07/25] block: bdrv_get_full_backing_filename's " Max Reitz
2017-01-16 22:00 ` Eric Blake
2017-01-16 20:49 ` [Qemu-devel] [PATCH v4 08/25] block: Add bdrv_make_absolute_filename() Max Reitz
2017-01-16 20:49 ` [Qemu-devel] [PATCH v4 09/25] block: Fix bdrv_find_backing_image() Max Reitz
2017-01-16 22:08 ` Eric Blake
2017-01-16 20:49 ` [Qemu-devel] [PATCH v4 10/25] block: Add bdrv_dirname() Max Reitz
2017-01-16 23:02 ` Eric Blake
2017-01-18 13:33 ` Max Reitz
2017-01-16 20:49 ` [Qemu-devel] [PATCH v4 11/25] blkverify: Make bdrv_dirname() return NULL Max Reitz
2017-01-16 23:09 ` Eric Blake [this message]
2017-01-16 20:49 ` [Qemu-devel] [PATCH v4 12/25] quorum: " Max Reitz
2017-01-16 23:13 ` Eric Blake
2017-01-16 20:49 ` [Qemu-devel] [PATCH v4 13/25] block/nbd: Implement bdrv_dirname() Max Reitz
2017-01-16 23:21 ` Eric Blake
2017-01-18 13:37 ` Max Reitz
2017-01-16 20:49 ` [Qemu-devel] [PATCH v4 14/25] block/nfs: " Max Reitz
2017-01-16 20:49 ` [Qemu-devel] [PATCH v4 15/25] block: Use bdrv_dirname() for relative filenames Max Reitz
2017-01-16 20:49 ` [Qemu-devel] [PATCH v4 16/25] block: Add 'base-directory' BDS option Max Reitz
2017-01-16 20:49 ` [Qemu-devel] [PATCH v4 17/25] iotests: Add quorum case to test 110 Max Reitz
2017-01-16 20:51 ` [Qemu-devel] [PATCH v4 18/25] block: Add sgfnt_runtime_opts to BlockDriver Max Reitz
2017-01-16 20:51 ` [Qemu-devel] [PATCH v4 19/25] block: Add BlockDriver.bdrv_gather_child_options Max Reitz
2017-01-16 20:51 ` [Qemu-devel] [PATCH v4 20/25] block: Generically refresh runtime options Max Reitz
2017-01-16 20:51 ` [Qemu-devel] [PATCH v4 21/25] block: Purify .bdrv_refresh_filename() Max Reitz
2017-01-16 20:51 ` [Qemu-devel] [PATCH v4 22/25] block: Do not copy exact_filename from format file Max Reitz
2017-01-16 20:51 ` [Qemu-devel] [PATCH v4 23/25] block: Fix FIXME from "Add BDS.backing_overridden" Max Reitz
2017-01-16 20:51 ` [Qemu-devel] [PATCH v4 24/25] block/curl: Implement bdrv_refresh_filename() Max Reitz
2017-01-16 20:51 ` [Qemu-devel] [PATCH v4 25/25] block/null: Generate filename even with latency-ns Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cde665c6-4ad7-81b8-3d9e-a38145862bd3@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).