Re: [Qemu-devel] [PATCH v2 1/3] glib: bump min required glib library version to 2.40

[Thomas Huth <thuth@redhat.com>]

On 06.06.2018 19:32, Daniel P. Berrangé wrote:
> Per supported platforms doc, the various min glib on relevant distros is:
> 
>   RHEL-7: 2.50.3
>   Debian (Stretch): 2.50.3
>   Debian (Jessie): 2.42.1
>   OpenBSD (Ports): 2.54.3
>   FreeBSD (Ports): 2.50.3
>   OpenSUSE Leap 15: 2.54.3
>   Ubuntu (Xenial): 2.48.0
>   macOS (Homebrew): 2.56.0
> 
> This suggests that a minimum glib of 2.42 is a reasonable target.
> 
> The GLibC compile farm, however, uses Ubuntu 14.04 (Trusty) which only
> has glib 2.40.0, and this is needed for testing during merge. Thus an
> exception is made to the documented platform support policy to allow for
> all three current LTS releases to be supported.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  configure               |   6 +-
>  crypto/hash-glib.c      |   4 -
>  crypto/hmac-glib.c      |  36 -----
>  include/glib-compat.h   | 319 ----------------------------------------
>  qga/commands.c          |  11 +-
>  tests/ivshmem-test.c    |   6 -
>  tests/test-qmp-event.c  |   8 +-
>  tests/tpm-emu.h         |   4 +-
>  tests/vhost-user-test.c |  26 +---
>  trace/simple.c          |   6 +-
>  util/osdep.c            |  14 --
>  11 files changed, 11 insertions(+), 429 deletions(-)

Great diffstat!

And the changes look fine to me:

Reviewed-by: Thomas Huth <thuth@redhat.com>