From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB0A4C433E0 for ; Sat, 30 Jan 2021 06:48:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27AEF64D9E for ; Sat, 30 Jan 2021 06:48:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27AEF64D9E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5k3j-0007xJ-On for qemu-devel@archiver.kernel.org; Sat, 30 Jan 2021 01:48:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5k37-0007Qn-HM for qemu-devel@nongnu.org; Sat, 30 Jan 2021 01:48:01 -0500 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:40050) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5k35-0002BA-My for qemu-devel@nongnu.org; Sat, 30 Jan 2021 01:48:01 -0500 Received: by mail-pg1-x530.google.com with SMTP id b21so8114102pgk.7 for ; Fri, 29 Jan 2021 22:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yuO2ntIrGrFUude//VlLzEY0+iKc3vtBLzDra/FRCAs=; b=Xbu1KFo7YfPPYdZCia8215HT46NoFjw9MkNYkwu8gXhmoFyEh3JMciY99LlOwZ8SkS jiqwhHhwzaBoMTbxfL5KpPFGhAm2GBCuNa24R9sw7xyDrIovZ+fMtxLmrNh1vKD0R9p9 YiFWd9PLlPpngVSkRt2lW+RSFvIob2xFwYqrXtn5fnWGAZZXxQQNi6xUTF9xNaVqi8X3 xg2RFGD5iDWAsDetfOl19U9MZ0HKHL/qRzvBG/k3Vg9LwRdvsaeR3uauzpP42kTsk2Zd yyj6ybyPlbO8H8yFdPU9y2fKf2V6CG3cW2vBixCseo5Xz0mgC2wGuGslgvm19fIagJ4C L/5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yuO2ntIrGrFUude//VlLzEY0+iKc3vtBLzDra/FRCAs=; b=lreB2di2TIkNyK+nKPU+nzFqLWwJP5BVxzfenupUJUHIVOpvYIyay8r0KzSidChlw3 PoSAe6QEByoFeKQj5+y/2aXfFbnOLWjKbxNarGl4obmpXliokYjW7YXzhwZm2T+K/W69 hq5nw+YrJoR9MT2IB5ozhAhIxC2dMJJ7AK/6KsIU0TLO4tg0Tlu3oPgvBDwdJfJ0uya2 1A3oe9N8bc7rqO57+25gqDybL5MCK73HfaWkgmIvObUApK4A2U+eS2jm1jQUNHIhkk62 ITe+4Wkc9kD590R5Z9Bhk9U+FKU5ctdS0OUNgSZ8SJR8DlWEViQ7o2h2vS0bcW3qHRQV eckw== X-Gm-Message-State: AOAM533SzkYVwrJCwlRm5Kk4C096vrW0h5KUYWI4aOYcSTbUZP/IHQ61 27Qy3ecr7gMxb4Vk/WYNKzEkVSprpzS68HyN X-Google-Smtp-Source: ABdhPJyfr2SVw5vVvFDA+ijZS7r6n3QbnAjq2yvIQf7/ls7bImqU7cGzixw/8WW0pc7T9kMg267+XA== X-Received: by 2002:a63:a542:: with SMTP id r2mr7977627pgu.211.1611989277664; Fri, 29 Jan 2021 22:47:57 -0800 (PST) Received: from [192.168.3.43] (cpe-66-27-222-29.hawaii.res.rr.com. [66.27.222.29]) by smtp.gmail.com with ESMTPSA id h1sm10870999pgj.59.2021.01.29.22.47.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jan 2021 22:47:57 -0800 (PST) Subject: Re: [PATCH v3 02/24] tcg/tci: Remove TCG_TARGET_HAS_* ifdefs To: Peter Maydell References: <20210129201028.787853-1-richard.henderson@linaro.org> <20210129201028.787853-3-richard.henderson@linaro.org> From: Richard Henderson Message-ID: Date: Fri, 29 Jan 2021 20:47:53 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/29/21 1:16 PM, Peter Maydell wrote: > On Fri, 29 Jan 2021 at 20:13, Richard Henderson > wrote: >> >> The opcodes always exist, regardless of whether or not they >> are enabled. Remove the unnecessary ifdefs. >> >> Signed-off-by: Richard Henderson >> --- >> tcg/tci/tcg-target.c.inc | 82 ---------------------------------------- >> 1 file changed, 82 deletions(-) >> >> diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc >> index 9c45f5f88f..b62e14d5ce 100644 >> --- a/tcg/tci/tcg-target.c.inc >> +++ b/tcg/tci/tcg-target.c.inc >> @@ -71,70 +71,42 @@ static const TCGTargetOpDef tcg_target_op_defs[] = { >> { INDEX_op_add_i32, { R, RI, RI } }, >> { INDEX_op_sub_i32, { R, RI, RI } }, >> { INDEX_op_mul_i32, { R, RI, RI } }, >> -#if TCG_TARGET_HAS_div_i32 >> { INDEX_op_div_i32, { R, R, R } }, >> { INDEX_op_divu_i32, { R, R, R } }, >> { INDEX_op_rem_i32, { R, R, R } }, >> { INDEX_op_remu_i32, { R, R, R } }, >> -#elif TCG_TARGET_HAS_div2_i32 >> - { INDEX_op_div2_i32, { R, R, "0", "1", R } }, >> - { INDEX_op_divu2_i32, { R, R, "0", "1", R } }, >> -#endif > >> -#if TCG_TARGET_HAS_div_i64 >> { INDEX_op_div_i64, { R, R, R } }, >> { INDEX_op_divu_i64, { R, R, R } }, >> { INDEX_op_rem_i64, { R, R, R } }, >> { INDEX_op_remu_i64, { R, R, R } }, >> -#elif TCG_TARGET_HAS_div2_i64 >> - { INDEX_op_div2_i64, { R, R, "0", "1", R } }, >> - { INDEX_op_divu2_i64, { R, R, "0", "1", R } }, >> -#endif > > Why are div2/divu2 special cases such that their entries > get deleted rather than unconditionally included ? Because div/div2 are mutually exclusive. r~