From: Eric Blake <eblake@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com,
Alexey <a.perevalov@samsung.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PULL 00/14] Migration pull request
Date: Thu, 4 Jan 2018 18:30:32 -0600 [thread overview]
Message-ID: <ce168bf2-8e61-1f62-8042-7e7df2decd8c@redhat.com> (raw)
In-Reply-To: <20180103093834.20879-1-quintela@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]
On 01/03/2018 03:38 AM, Juan Quintela wrote:
> Hi
>
> This are the changes for migration that are already reviewed.
>
> Please, apply.
>
> Alexey Perevalov (6):
> migration: introduce postcopy-blocktime capability
> migration: add postcopy blocktime ctx into MigrationIncomingState
> migration: calculate vCPU blocktime on dst side
> migration: postcopy_blocktime documentation
> migration: add blocktime calculation into migration-test
> migration: add postcopy total blocktime into query-migrate
I had unanswered questions about these patches in the v12 series, where
I'm not sure if the interface is still quite right. We're still early
enough that we could adjust the interface after the fact depending on
how the questions are answered; but we're also early enough that it may
be smarter to get the interface right before including it in a pull
request. I'll leave it to Peter and Juan to sort out whether this means
an updated pull request is needed, or to take this as-is.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-01-05 0:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 9:38 [Qemu-devel] [PULL 00/14] Migration pull request Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 01/14] migration: Use proper types in json Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 02/14] migration: print features as on off Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 03/14] migration: free addr in the same function that we created it Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 04/14] docs: Convert migration.txt to rst Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 05/14] migration: free result string Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 06/14] migration: fix analyze-migration.py script with radix table Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 07/14] migration: introduce postcopy-blocktime capability Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 08/14] migration: add postcopy blocktime ctx into MigrationIncomingState Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 09/14] migration: calculate vCPU blocktime on dst side Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 10/14] migration: postcopy_blocktime documentation Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 11/14] migration: add blocktime calculation into migration-test Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 12/14] migration: add postcopy total blocktime into query-migrate Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 13/14] migration: Guard ram_bytes_remaining against early call Juan Quintela
2018-01-03 9:38 ` [Qemu-devel] [PULL 14/14] migration: finalize current_migration object Juan Quintela
2018-01-05 0:30 ` Eric Blake [this message]
2018-01-05 9:29 ` [Qemu-devel] [PULL 00/14] Migration pull request Dr. David Alan Gilbert
2018-01-05 9:59 ` Juan Quintela
2018-01-09 18:24 ` Peter Maydell
2018-01-09 18:28 ` Juan Quintela
2018-01-10 4:58 ` Alexey Perevalov
2018-01-11 11:51 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2017-06-13 9:51 [Qemu-devel] [PULL 00/14] Migration PULL request Juan Quintela
2017-06-13 13:40 ` Peter Maydell
2015-11-19 11:20 [Qemu-devel] [PULL 00/14] Migration pull request Juan Quintela
2015-11-19 13:12 ` Peter Maydell
2015-11-19 13:21 ` Peter Maydell
2015-11-19 14:44 ` Peter Maydell
2015-11-19 15:03 ` Peter Maydell
2015-11-19 15:16 ` Dr. David Alan Gilbert
2015-11-20 8:03 ` Peter Lieven
2015-11-20 9:38 ` Peter Lieven
2015-11-20 11:33 ` Peter Maydell
2015-11-20 13:44 ` Peter Lieven
2015-11-20 13:53 ` Kevin Wolf
2015-11-20 14:00 ` Peter Lieven
2015-11-20 14:15 ` Kevin Wolf
2015-11-19 17:32 ` John Snow
2015-11-19 15:56 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce168bf2-8e61-1f62-8042-7e7df2decd8c@redhat.com \
--to=eblake@redhat.com \
--cc=a.perevalov@samsung.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).