From: Thomas Huth <thuth@redhat.com>
To: Mahmoud Mandour <ma.mandourr@gmail.com>, qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH 1/2] util/compatfd.c: Fixed style issues
Date: Mon, 15 Mar 2021 15:51:01 +0100 [thread overview]
Message-ID: <ce1f990d-8b7b-218a-293e-ed1ed1e85409@redhat.com> (raw)
In-Reply-To: <20210315105814.5188-2-ma.mandourr@gmail.com>
On 15/03/2021 11.58, Mahmoud Mandour wrote:
> Fixed two styling issues that caused checkpatch.pl errors.
>
> Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
> ---
> util/compatfd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/util/compatfd.c b/util/compatfd.c
> index ee47dd8089..174f394533 100644
> --- a/util/compatfd.c
> +++ b/util/compatfd.c
> @@ -20,8 +20,7 @@
> #include <sys/syscall.h>
> #endif
>
> -struct sigfd_compat_info
> -{
> +struct sigfd_compat_info {
> sigset_t mask;
> int fd;
> };
> @@ -53,8 +52,9 @@ static void *sigwait_compat(void *opaque)
>
> len = write(info->fd, (char *)&buffer + offset,
> sizeof(buffer) - offset);
> - if (len == -1 && errno == EINTR)
> + if (len == -1 && errno == EINTR) {
> continue;
> + }
>
> if (len <= 0) {
> return NULL;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-03-15 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 10:58 [PATCH 0/2] util/compatfd.c: Fixed styling and replaced malloc Mahmoud Mandour
2021-03-15 10:58 ` [PATCH 1/2] util/compatfd.c: Fixed style issues Mahmoud Mandour
2021-03-15 14:51 ` Thomas Huth [this message]
2021-03-15 10:58 ` [PATCH 2/2] util/compatfd.c: Replaced a malloc call with g_malloc Mahmoud Mandour
2021-03-15 11:13 ` Philippe Mathieu-Daudé
2021-03-15 11:30 ` Mahmoud Mandour
2021-03-15 14:25 ` Markus Armbruster
2021-03-15 14:53 ` Thomas Huth
2021-03-15 15:13 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1f990d-8b7b-218a-293e-ed1ed1e85409@redhat.com \
--to=thuth@redhat.com \
--cc=ma.mandourr@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).