qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez Martin" <eperezma@redhat.com>,
	"German Maglione" <gmaglione@redhat.com>,
	"Liu Jiang" <gerry@linux.alibaba.com>,
	"Sergio Lopez Pascual" <slp@redhat.com>,
	"Stefano Garzarella" <sgarzare@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2 1/7] vhost-user: strip superfluous whitespace
Date: Thu, 31 Aug 2023 09:13:08 +0200	[thread overview]
Message-ID: <ce2b4c96-8a6b-247c-14eb-b3a6c81973f0@redhat.com> (raw)
In-Reply-To: <20230830134055.106812-2-lersek@redhat.com>

On 8/30/23 15:40, Laszlo Ersek wrote:
> Cc: "Michael S. Tsirkin" <mst@redhat.com> (supporter:vhost)
> Cc: Eugenio Perez Martin <eperezma@redhat.com>
> Cc: German Maglione <gmaglione@redhat.com>
> Cc: Liu Jiang <gerry@linux.alibaba.com>
> Cc: Sergio Lopez Pascual <slp@redhat.com>
> Cc: Stefano Garzarella <sgarzare@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> 
> Notes:
>     v2:
>     
>     - pick up Stefano's R-b
> 
>  hw/virtio/vhost-user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This has been

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

under the (identical) v1 posting:

http://mid.mail-archive.com/cd0604a1-6826-ac6c-6c47-dcb6def64b28@linaro.org

Thanks, Phil! (and sorry that I posted v2 too quickly -- I forgot that
sometimes reviewers split a review over multiple days.)

Laszlo

> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 8dcf049d422b..b4b677c1ce66 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -398,7 +398,7 @@ static int vhost_user_write(struct vhost_dev *dev, VhostUserMsg *msg,
>       * operations such as configuring device memory mappings or issuing device
>       * resets, which affect the whole device instead of individual VQs,
>       * vhost-user messages should only be sent once.
> -     * 
> +     *
>       * Devices with multiple vhost_devs are given an associated dev->vq_index
>       * so per_device requests are only sent if vq_index is 0.
>       */
> 



  reply	other threads:[~2023-08-31  7:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 13:40 [PATCH v2 0/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously Laszlo Ersek
2023-08-30 13:40 ` [PATCH v2 1/7] vhost-user: strip superfluous whitespace Laszlo Ersek
2023-08-31  7:13   ` Laszlo Ersek [this message]
2023-09-06  7:12     ` Albert Esteve
2023-09-06  9:09       ` Laszlo Ersek
2023-10-02 19:48       ` Laszlo Ersek
2023-08-30 13:40 ` [PATCH v2 2/7] vhost-user: tighten "reply_supported" scope in "set_vring_addr" Laszlo Ersek
2023-08-31  7:14   ` Laszlo Ersek
2023-08-30 13:40 ` [PATCH v2 3/7] vhost-user: factor out "vhost_user_write_sync" Laszlo Ersek
2023-08-30 13:40 ` [PATCH v2 4/7] vhost-user: flatten "enforce_reply" into "vhost_user_write_sync" Laszlo Ersek
2023-08-30 13:40 ` [PATCH v2 5/7] vhost-user: hoist "write_sync", "get_features", "get_u64" Laszlo Ersek
2023-08-31  7:20   ` Laszlo Ersek
2023-09-06  9:59     ` Philippe Mathieu-Daudé
2023-08-30 13:40 ` [PATCH v2 6/7] vhost-user: allow "vhost_set_vring" to wait for a reply Laszlo Ersek
2023-08-30 13:40 ` [PATCH v2 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously Laszlo Ersek
2023-09-07 15:59   ` Eugenio Perez Martin
2023-09-07 20:27     ` Laszlo Ersek
2023-09-07 16:01 ` [PATCH v2 0/7] " Eugenio Perez Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce2b4c96-8a6b-247c-14eb-b3a6c81973f0@redhat.com \
    --to=lersek@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=gerry@linux.alibaba.com \
    --cc=gmaglione@redhat.com \
    --cc=mst@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=slp@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).