From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Anton Johansson <anjo@rev.ng>, qemu-devel@nongnu.org
Cc: ale@rev.ng, richard.henderson@linaro.org, pbonzini@redhat.com,
eduardo@habkost.net, peter.maydell@linaro.org, mrolnik@gmail.com,
tsimpson@quicinc.com, gaosong@loongson.cn,
yangxiaojuan@loongson.cn, edgar.iglesias@gmail.com,
shorne@gmail.com, palmer@dabbelt.com, alistair.francis@wdc.com,
bin.meng@windriver.com, ysato@users.sourceforge.jp,
mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com,
kbastian@mail.uni-paderborn.de
Subject: Re: [PATCH v2 00/27] Replace TARGET_TB_PCREL with CF_PCREL
Date: Tue, 21 Feb 2023 23:39:11 +0100 [thread overview]
Message-ID: <ce377100-946e-7dd7-2795-ab63d484f15b@linaro.org> (raw)
In-Reply-To: <20230221221818.9382-1-anjo@rev.ng>
On 21/2/23 23:17, Anton Johansson wrote:
> This patchset entirely replaces the macro TARGET_TB_PCREL with
> a field in TranslationBlock.cflags called CF_PCREL, and is a
> first step towards removing target-specific assumptions from
> non-target/ directories.
>
> The grand goal is to allow for heterogeneous QEMU binaries
> consisting of multiple frontends.
>
> RFC: https://lists.nongnu.org/archive/html/qemu-devel/2022-12/msg04518.html
>
> Changes in v2:
> * Setting of CF_PCREL (previously patch 3) was split in two and moved
> up front (to patch 2 and 3);
>
> * Replacing of TARGET_TB_PCREL (previously patch 2) was split into
> four patches (patches [4,7]), one for each affected submodule;
>
> * Removal of TARGET_TB_PCREL (previously patch 3) was moved into
> separate patches, one for each submodule (patches [8,10]);
>
> * Patch 11 was introduced in response to feedback, and removes
> CF_PCREL checks in functions in tb-jmp-cache.h, these functions were
> always called in a context where CF_PCREL was already being checked.
> These tb-jmp-cache.h functions were then removed in favour of manual
> inlining;
>
> * Patches [12,26] replaces calls to tb_pc() with a member access
> tb->pc, the motivation being that tb_pc() was (almost) always called
> in a context where CF_PCREL was already being checked;
>
> * Finally patch 27 removes tb_pc() which is no longer used.
>
> Since changes are spread across multiple submodules we ended up with a
> lot of patches. Patches [11,27] still need review.
>
> Anton Johansson (27):
> include/exec: Introduce `CF_PCREL`
> target/i386: set `CF_PCREL` in `x86_cpu_realizefn`
> target/arm: set `CF_PCREL` in `arm_cpu_realizefn`
> accel/tcg: Replace `TARGET_TB_PCREL` with `CF_PCREL`
> include/exec: Replace `TARGET_TB_PCREL` with `CF_PCREL`
> target/arm: Replace `TARGET_TB_PCREL` with `CF_PCREL`
> target/i386: Replace `TARGET_TB_PCREL` with `CF_PCREL`
> include/exec: Remove `TARGET_TB_PCREL` define
> target/arm: Remove `TARGET_TB_PCREL` define
> target/i386: Remove `TARGET_TB_PCREL` define
> accel/tcg: Move jmp-cache `CF_PCREL` checks to caller
> accel/tcg: Replace `tb_pc()` with `tb->pc`
> target/tricore: Replace `tb_pc()` with `tb->pc`
> target/sparc: Replace `tb_pc()` with `tb->pc`
> target/sh4: Replace `tb_pc()` with `tb->pc`
> target/rx: Replace `tb_pc()` with `tb->pc`
> target/riscv: Replace `tb_pc()` with `tb->pc`
> target/openrisc: Replace `tb_pc()` with `tb->pc`
> target/mips: Replace `tb_pc()` with `tb->pc`
> target/microblaze: Replace `tb_pc()` with `tb->pc`
> target/loongarch: Replace `tb_pc()` with `tb->pc`
> target/i386: Replace `tb_pc()` with `tb->pc`
> target/hppa: Replace `tb_pc()` with `tb->pc`
> target/hexagon: Replace `tb_pc()` with `tb->pc`
> target/avr: Replace `tb_pc()` with `tb->pc`
> target/arm: Replace `tb_pc()` with `tb->pc`
> include/exec: Remove `tb_pc()`
Series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-02-21 22:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 22:17 [PATCH v2 00/27] Replace TARGET_TB_PCREL with CF_PCREL Anton Johansson via
2023-02-21 22:17 ` [PATCH v2 01/27] include/exec: Introduce `CF_PCREL` Anton Johansson via
2023-02-21 22:17 ` [PATCH v2 02/27] target/i386: set `CF_PCREL` in `x86_cpu_realizefn` Anton Johansson via
2023-02-21 22:17 ` [PATCH v2 03/27] target/arm: set `CF_PCREL` in `arm_cpu_realizefn` Anton Johansson via
2023-02-21 22:17 ` [PATCH v2 04/27] accel/tcg: Replace `TARGET_TB_PCREL` with `CF_PCREL` Anton Johansson via
2023-02-21 22:17 ` [PATCH v2 05/27] include/exec: " Anton Johansson via
2023-02-21 22:17 ` [PATCH v2 06/27] target/arm: " Anton Johansson via
2023-02-21 22:17 ` [PATCH v2 07/27] target/i386: " Anton Johansson via
2023-02-21 22:17 ` [PATCH v2 08/27] include/exec: Remove `TARGET_TB_PCREL` define Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 09/27] target/arm: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 10/27] target/i386: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 11/27] accel/tcg: Move jmp-cache `CF_PCREL` checks to caller Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 12/27] accel/tcg: Replace `tb_pc()` with `tb->pc` Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 13/27] target/tricore: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 14/27] target/sparc: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 15/27] target/sh4: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 16/27] target/rx: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 17/27] target/riscv: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 18/27] target/openrisc: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 19/27] target/mips: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 20/27] target/microblaze: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 21/27] target/loongarch: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 22/27] target/i386: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 23/27] target/hppa: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 24/27] target/hexagon: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 25/27] target/avr: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 26/27] target/arm: " Anton Johansson via
2023-02-21 22:18 ` [PATCH v2 27/27] include/exec: Remove `tb_pc()` Anton Johansson via
2023-02-21 22:39 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce377100-946e-7dd7-2795-ab63d484f15b@linaro.org \
--to=philmd@linaro.org \
--cc=ale@rev.ng \
--cc=alistair.francis@wdc.com \
--cc=anjo@rev.ng \
--cc=atar4qemu@gmail.com \
--cc=bin.meng@windriver.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=gaosong@loongson.cn \
--cc=kbastian@mail.uni-paderborn.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mrolnik@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shorne@gmail.com \
--cc=tsimpson@quicinc.com \
--cc=yangxiaojuan@loongson.cn \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).